Skip to content

Update gradle to version 9.2.0 and migrate to java 25#34

Open
bockthom wants to merge 1 commit intose-sic:masterfrom
bockthom:thomas-fixes
Open

Update gradle to version 9.2.0 and migrate to java 25#34
bockthom wants to merge 1 commit intose-sic:masterfrom
bockthom:thomas-fixes

Conversation

@bockthom
Copy link
Collaborator

Since the last gradle and java version updates have been made a couple of years ago, it is time for a major version update now again.

@bockthom
Copy link
Collaborator Author

@Leo-Send I noticed a few differences in the log output that worry me. As I had to update the java version on our cluster container, I updated it to the most recent version. However, I am not sure whether the unexpected log outputs are due to your changes in PR #31 and PR #33, or whether these changes are due to updating to Java 25. Could you please check by our next meeting whether your can encounter the following changes on you machine using your test repos as well using your previously used java version, and if not, whether you code works on your machine using Java 25 as expected or not.

In particular, I noticed the following differences:

Previously, we received log output like this:

INFO: Querying URL: https://api.github.com/repos/gogs/gogs/issues?state=all&per_page=100
Mar 06, 2023 6:22:22 PM de.uni_passau.fim.gitwrapper.GitHubRepository getJSONStringFromURL
INFO: Querying URL: https://api.github.com/repositories/16752620/issues?state=all&per_page=100&page=2
Mar 06, 2023 6:22:24 PM de.uni_passau.fim.gitwrapper.GitHubRepository getJSONStringFromURL
INFO: Querying URL: https://api.github.com/repositories/16752620/issues?state=all&per_page=100&page=3
...

Now, these INFO outputs for querying an URL are completely gone. Instead, we have thousands of warnings like the following:

Nov 16, 2025 10:37:14 PM de.uni_passau.fim.gitwrapper.Repository lambda$verify$30
WARNING: Failed to resolve '142d35e8d2baec230ddb565d1265940d59141fab' to its unique SHA1 hash.
Nov 16, 2025 10:37:14 PM de.uni_passau.fim.gitwrapper.Repository lambda$verify$30
WARNING: Failed to resolve '372c6435d66e7c5cfdb4c67732cb729f961e466f' to its unique SHA1 hash.
Nov 16, 2025 10:37:14 PM de.uni_passau.fim.gitwrapper.Repository lambda$verify$30
WARNING: Failed to resolve '5c5424301443ffa3659737d12de48ab1dfe39a00' to its unique SHA1 hash.
Nov 16, 2025 10:37:15 PM de.uni_passau.fim.gitwrapper.Repository lambda$verify$30
WARNING: Failed to resolve '94cd2ea3b680b43624b3285f10d5b01bb9e7df48' to its unique SHA1 hash.

And after this set of warnings, another set of warnings follows:

Nov 16, 2025 10:45:27 PM de.uni_passau.fim.gitwrapper.Commit lambda$getCommitInfo$8
WARNING: Failed to obtain information about commit 3a5132b6f79bf6e7f6080b3ff3b40a787a6fc503.
Nov 16, 2025 10:45:27 PM de.uni_passau.fim.gitwrapper.Commit lambda$getCommitInfo$8
WARNING: Failed to obtain information about commit 3a5132b6f79bf6e7f6080b3ff3b40a787a6fc503.
Nov 16, 2025 10:45:27 PM de.uni_passau.fim.gitwrapper.Commit lambda$getCommitInfo$8
WARNING: Failed to obtain information about commit 3a5132b6f79bf6e7f6080b3ff3b40a787a6fc503.
Nov 16, 2025 10:45:27 PM de.uni_passau.fim.gitwrapper.Commit lambda$getCommitInfo$8

A quick check revealed that these two kinds of warnings come from the dependency GitWrapper:

Warning "Failed to resolve ... to its unique SHA1 hash":
https://gitlab.infosun.fim.uni-passau.de/seibt/GitWrapper/-/blob/master/src/de/uni_passau/fim/gitwrapper/Repository.java?ref_type=heads#L413

Warning "Failed to obtain information about commit ...":
https://gitlab.infosun.fim.uni-passau.de/seibt/GitWrapper/-/blob/master/src/de/uni_passau/fim/gitwrapper/Commit.java?ref_type=heads#L300

The resulting output json file looks normal, though. But I am wondering what happens to all these commit hashes that cannot be resolved and cause these warnings 🤔

So @Leo-Send, could you please check the following:

  • 1. Do these kind of warnings also appear with your projects using the previously used java version?
  • 2. If not 1., do these kind of warnings appear when you switch to java 25?
  • 3. Do these warnings harm our results? What's wrong with these hashes?
  • 4. Why did the INFO log "Querying URL..." disappear?
  • 5. Do you have an idea how we can fix this in GitHubWrapper without touching the dependency GitWrapper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant