Update to reveal.js 4.0.0 plugin format and fix notes bug#14
Open
tty0482 wants to merge 2 commits intosebhildebrandt:masterfrom
Open
Update to reveal.js 4.0.0 plugin format and fix notes bug#14tty0482 wants to merge 2 commits intosebhildebrandt:masterfrom
tty0482 wants to merge 2 commits intosebhildebrandt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the plugin to the format specified by reveal.js 4.0.0.
It also fixes a bug with regards to notes and shuffling - previously, the shuffle could result in some of the tags being shuffled into the
Element, as the innerHTML lines were shuffled. The new version removes any child elements of the slide that are an Element or have the .notes class, then appends them again after the shuffle, thereby ensuring that all tags are still present and the speaker notes are preserved.