Fix cover handling by ccutrer · Pull Request #62 · seime/openhab-esphome

ccutrer · 2025-12-19T18:28:16Z

Don't create a legacy state channel anymore; current ESPHome doesn't even support it.
ALWAYS create the position channel - even if a cover doesn't support position, it reports and accepts position states/commands of 0 and 1 as closed/open.
Still send legacy cover commands when sending UP or DOWN to the position channel, in case it's an old device.
Revert the "always show tilt channel" commit; the has_tilt option in the entities response is accurate.

This reverts commit fc7a5dd.

* Don't create a legacy state channel anymore; current ESPHome doesn't even support it. * ALWAYS create the position channel - even if a cover doesn't support position, it reports and accepts position states/commands of 0 and 1 as closeed/open. * Still send legacy cover commands when sending UP or DOWN to the position channel. Signed-off-by: Cody Cutrer <cody@cutrer.us>

seime · 2025-12-20T15:37:10Z

FYI I'm currently away from my computer, but will take a look ASAP.

Copilot

Pull request overview

This PR refactors cover handling to align with current ESPHome behavior by removing deprecated legacy state channel support and adjusting how position and tilt channels are created and managed.

Key Changes:

Removes the legacy state channel that ESPHome no longer supports
Always creates the position channel for all covers (even those without explicit position support)
Adds legacy command support when UP/DOWN commands are sent to the position channel for backwards compatibility
Reverts to conditional tilt channel creation based on the supportsTilt flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-01T18:02:55Z

src/main/java/no/seime/openhab/binding/esphome/internal/message/CoverMessageHandler.java

+        if (rsp.getSupportsTilt()) {
+            semanticTags = createSemanticTags("Tilt", deviceClass);

-        ChannelType channelTypeState = addChannelType(rsp.getObjectId() + LEGACY_CHANNEL_STATE, "Legacy State",
-                deviceClass.getItemType(), createSemanticTags("OpenClose", deviceClass), icon, rsp.getEntityCategory(),
-                rsp.getDisabledByDefault());
-        StateDescription stateDescription = patternStateDescription("%s");
+            ChannelType channelTypeTilt = addChannelType(rsp.getObjectId() + CHANNEL_TILT, "Tilt",
+                    deviceClass.getItemType(), semanticTags, icon, rsp.getEntityCategory(), rsp.getDisabledByDefault());
+            stateDescription = patternStateDescription("%d %%");

-        Channel channelState = ChannelBuilder.create(createChannelUID(rsp.getObjectId(), LEGACY_CHANNEL_STATE))
-                .withLabel(createLabel(rsp.getName(), "Legacy State")).withKind(ChannelKind.STATE)
-                .withType(channelTypeState.getUID()).withAcceptedItemType(deviceClass.getItemType())
-                .withConfiguration(configuration(EntityTypes.COVER, rsp.getKey(), LEGACY_CHANNEL_STATE)).build();
-        super.registerChannel(channelState, channelTypeState, stateDescription);
+            Channel channelTilt = ChannelBuilder.create(createChannelUID(rsp.getObjectId(), CHANNEL_TILT))
+                    .withLabel(createLabel(rsp.getName(), "Tilt")).withKind(ChannelKind.STATE)
+                    .withType(channelTypeTilt.getUID()).withAcceptedItemType(deviceClass.getItemType())
+                    .withConfiguration(configuration(EntityTypes.COVER, rsp.getKey(), CHANNEL_TILT)).build();
+            super.registerChannel(channelTilt, channelTypeTilt, stateDescription);
+        }


The change to conditionally create the tilt channel based on the supportsTilt flag (reverting the "always show tilt channel" behavior) should be covered by tests. Consider adding test cases to verify that the tilt channel is only created when supportsTilt is true.

Copilot · 2026-01-01T18:02:56Z

src/main/java/no/seime/openhab/binding/esphome/internal/message/CoverMessageHandler.java

                        } else if (command == UpDownType.UP) {
+                            builder.setHasLegacyCommand(true);
+                            builder.setLegacyCommand(LegacyCoverCommand.LEGACY_COVER_COMMAND_OPEN);
                            builder.setPosition(1);
                        } else if (command == UpDownType.DOWN) {
+                            builder.setHasLegacyCommand(true);
+                            builder.setLegacyCommand(LegacyCoverCommand.LEGACY_COVER_COMMAND_CLOSE);
                            builder.setPosition(0);


The new behavior of sending legacy commands (LEGACY_COVER_COMMAND_OPEN and LEGACY_COVER_COMMAND_CLOSE) alongside position values when handling UP and DOWN commands on the position channel lacks test coverage. Consider adding unit tests similar to ClimateMessageHandlerTest to verify this command aggregation behavior.

Copilot · 2026-01-01T18:02:56Z

src/main/java/no/seime/openhab/binding/esphome/internal/message/CoverMessageHandler.java

+        Set<String> semanticTags = createSemanticTags("OpenLevel", deviceClass);

-            Channel channelPosition = ChannelBuilder.create(createChannelUID(rsp.getObjectId(), CHANNEL_POSITION))
-                    .withLabel(createLabel(rsp.getName(), "Position")).withKind(ChannelKind.STATE)
-                    .withType(channelTypePosition.getUID()).withAcceptedItemType(deviceClass.getItemType())
-                    .withConfiguration(configuration(EntityTypes.COVER, rsp.getKey(), CHANNEL_POSITION)).build();
-            super.registerChannel(channelPosition, channelTypePosition, stateDescription);
-        }
-
-        Set<String> semanticTags = createSemanticTags("Tilt", deviceClass);
-
-        ChannelType channelTypeTilt = addChannelType(rsp.getObjectId() + CHANNEL_TILT, "Tilt",
+        ChannelType channelTypePosition = addChannelType(rsp.getObjectId() + CHANNEL_POSITION, "Position",
                deviceClass.getItemType(), semanticTags, icon, rsp.getEntityCategory(), rsp.getDisabledByDefault());
-        StateDescription stateDescriptionTilt = patternStateDescription("%d %%");
+        StateDescription stateDescription = patternStateDescription("%d %%");

-        Channel channelTilt = ChannelBuilder.create(createChannelUID(rsp.getObjectId(), CHANNEL_TILT))
-                .withLabel(createLabel(rsp.getName(), "Tilt")).withKind(ChannelKind.STATE)
-                .withType(channelTypeTilt.getUID()).withAcceptedItemType(deviceClass.getItemType())
-                .withConfiguration(configuration(EntityTypes.COVER, rsp.getKey(), CHANNEL_TILT)).build();
-        super.registerChannel(channelTilt, channelTypeTilt, stateDescriptionTilt);
+        Channel channelPosition = ChannelBuilder.create(createChannelUID(rsp.getObjectId(), CHANNEL_POSITION))
+                .withLabel(createLabel(rsp.getName(), "Position")).withKind(ChannelKind.STATE)
+                .withType(channelTypePosition.getUID()).withAcceptedItemType(deviceClass.getItemType())
+                .withConfiguration(configuration(EntityTypes.COVER, rsp.getKey(), CHANNEL_POSITION)).build();
+        super.registerChannel(channelPosition, channelTypePosition, stateDescription);


The change to always create the position channel regardless of the supportsPosition flag represents a significant behavioral change that should be covered by tests. Consider adding test cases to verify that the position channel is created for all covers, including those where supportsPosition is false.

seime · 2026-01-04T06:55:47Z

Thanks for contributing @ccutrer !

ccutrer added 2 commits December 19, 2025 11:25

Revert "Always show tilt channel on cover entities"

e398adb

This reverts commit fc7a5dd.

ccutrer force-pushed the fix-covers branch from 6ef744f to 8ad9686 Compare December 19, 2025 18:29

seime requested a review from Copilot January 1, 2026 17:58

Copilot started reviewing on behalf of seime January 1, 2026 17:59 View session

Copilot AI reviewed Jan 1, 2026

View reviewed changes

seime merged commit a14a439 into seime:master Jan 4, 2026
8 checks passed

ccutrer deleted the fix-covers branch January 4, 2026 07:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix cover handling#62

Fix cover handling#62
seime merged 2 commits intoseime:masterfrom
ccutrer:fix-covers

ccutrer commented Dec 19, 2025

Uh oh!

seime commented Dec 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 1, 2026

Uh oh!

Copilot AI Jan 1, 2026

Uh oh!

Copilot AI Jan 1, 2026

Uh oh!

Uh oh!

seime commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

ccutrer commented Dec 19, 2025

Uh oh!

seime commented Dec 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seime commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants