Skip to content

Add VS 2026 detection from MSVC v145#2063

Open
Dimi1010 wants to merge 2 commits intoseladb:devfrom
Dimi1010:cmake/msvc-toolset-v145
Open

Add VS 2026 detection from MSVC v145#2063
Dimi1010 wants to merge 2 commits intoseladb:devfrom
Dimi1010:cmake/msvc-toolset-v145

Conversation

@Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Feb 4, 2026

Adds visual studio version detection from toolset MSVC v145 which was shipped with Visual Studio 2026

@Dimi1010 Dimi1010 requested a review from seladb as a code owner February 4, 2026 08:58
@Dimi1010 Dimi1010 added the build any build issue label Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.82%. Comparing base (27830b3) to head (4c77223).

Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #2063    +/-   ##
========================================
  Coverage   83.81%   83.82%            
========================================
  Files         313      313            
  Lines       55663    55673    +10     
  Branches    11521    11565    +44     
========================================
+ Hits        46656    46666    +10     
- Misses       7794     8234   +440     
+ Partials     1213      773   -440     
Flag Coverage Δ
alpine320 76.40% <ø> (ø)
fedora42 76.13% <ø> (?)
macos-14 81.98% <ø> (ø)
macos-15 81.97% <ø> (+<0.01%) ⬆️
mingw32 70.34% <ø> (-0.02%) ⬇️
mingw64 70.35% <ø> (+0.09%) ⬆️
npcap ?
rhel94 75.75% <ø> (ø)
ubuntu2004 59.59% <ø> (?)
ubuntu2004-zstd 59.70% <ø> (ø)
ubuntu2204 75.71% <ø> (+<0.01%) ⬆️
ubuntu2204-icpx 59.08% <ø> (-0.01%) ⬇️
ubuntu2404 76.06% <ø> (ø)
ubuntu2404-arm64 76.07% <ø> (ø)
unittest 83.82% <ø> (+<0.01%) ⬆️
windows-2022 85.62% <ø> (+0.12%) ⬆️
windows-2025 85.65% <ø> (+0.13%) ⬆️
winpcap 85.65% <ø> (-0.09%) ⬇️
xdp 51.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@seladb
Copy link
Owner

seladb commented Feb 5, 2026

@Dimi1010 should we update this page in our docs?

@Dimi1010
Copy link
Collaborator Author

Dimi1010 commented Feb 5, 2026

@Dimi1010 should we update this page in our docs?

@seladb Maybe? Also the "continiously tested" against VS 2019 is incorrect. We only test on VS 2022 now. :/

@seladb
Copy link
Owner

seladb commented Feb 6, 2026

@Dimi1010 should we update this page in our docs?

@seladb Maybe? Also the "continiously tested" against VS 2019 is incorrect. We only test on VS 2022 now. :/

Do you want to open a PR in https://github.com/PcapPlusPlus/pcapplusplus.github.io for it or do you prefer me to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build any build issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants