Skip to content

TODO Add input validation for component_id #34

@mfaferek93

Description

@mfaferek93

Summary

The REST API endpoint /components/{component_id}/data doesn't validate the component_id parameter. While invalid IDs are rejected by cache lookup, validating early would provide better error messages and security.

Proposed solution

Add validation to whitelist ROS 2 naming conventions:

  • Allow: alphanumeric characters, underscores, forward slashes
  • Reject: special characters, escape sequences
  • URL-decode the parameter if necessary

Additional context

Related code: src/ros2_medkit_gateway/src/rest_server.cpp:246-248
Similar validation should apply to area_id in /areas/{area_id}/components

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions