fix(website): prevent NaN index access in circularSlice utility#1058
Open
sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
Open
fix(website): prevent NaN index access in circularSlice utility#1058sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What kind of change does this PR introduce? Bug fix
What is the current behavior? The
circularSlicefunction returns an array ofundefinedvalues when called with an empty input array, due to modulo operation with zero ((index + i) % 0results inNaN).What is the new behavior? The function now returns an empty array
[]for empty input arrays or non-positive item counts, preventingNaNindex access and subsequent rendering issues.Does this PR introduce a breaking change? No
Related Issue(s)
N/A - Internal code quality improvement
Other information
This fix prevents potential runtime errors when the
circularSliceutility is used with empty arrays, ensuring consistent behavior and preventing downstream issues in components that rely on this utility.