refactor(cli): eliminate duplicate spinner.stop() calls in getGroupIds#1083
Open
sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
Open
refactor(cli): eliminate duplicate spinner.stop() calls in getGroupIds#1083sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
sashaodessa wants to merge 1 commit intosemaphore-protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring — code structure improvement
What is the current behavior?
The
getGroupIdsfunction callsspinner.stop()in multiple places (lines 25, 32, and 34 in the original code), creating code duplication across different execution paths.What is the new behavior?
The spinner cleanup is now centralized in a
finallyblock, ensuring it stops exactly once regardless of the execution path (success, error, or early return). This eliminates duplication and reduces the risk of forgetting to stop the spinner in future code changes.Does this PR introduce a breaking change?
No. The behavior is identical — the spinner stops at the same point in execution, and error messages are displayed in the same order.
Related Issue(s)
N/A — code quality improvement