Skip to content

[CLNP-8108][fix]: Fixed a bug where the message list did not scroll to the startingPoint set on the GroupChannel #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danney-chun merged 4 commits into from
Feb 4, 2026
Merged

[CLNP-8108][fix]: Fixed a bug where the message list did not scroll to the startingPoint set on the GroupChannel #1397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
653c99d
Fixed a bug where the message list did not scroll to the startingPoin…
danney-chun Feb 3, 2026
28487f8
apply feed
danney-chun Feb 3, 2026
8f48f11
fixed test
danney-chun Feb 3, 2026
36a2c27
apply feed
danney-chun Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/GroupChannel/context/GroupChannelProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,10 @@ const GroupChannelManager :React.FC<React.PropsWithChildren<GroupChannelProvider

// Starting point handling
useEffect(() => {
if (typeof startingPoint === 'number' && messageDataSource.initialized) {
if (typeof startingPoint === 'number' && state.initialized) {
actions.scrollToMessage(startingPoint, 0, false, false);
}
}, [messageDataSource.initialized, startingPoint]);
}, [state.initialized, startingPoint]);

// Animated message handling
useEffect(() => {
Expand Down
19 changes: 16 additions & 3 deletions src/modules/GroupChannel/context/hooks/useGroupChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,22 @@ export const useGroupChannel = () => {
clickHandler.deactivate();

setAnimatedMessageId(null);
const message = state.messages.find(
(it) => it.messageId === messageId || it.createdAt === createdAt,
);

let message = null;
if (messageId) {
message = state.messages.find((it) => it.messageId === messageId);
} else if (createdAt) {
let distance = Number.MAX_SAFE_INTEGER;
for (const it of state.messages) {
const diff = Math.abs(it.createdAt - createdAt);
if (diff <= distance) {
distance = diff;
message = it;
} else {
break;
}
}
}

if (message) {
const topOffset = getMessageTopOffset(message.createdAt);
Expand Down