#137 Improve linting

.github/linters/.golangci.yaml

@@ -13,7 +13,7 @@ linters:
     - copyloopvar
     - cyclop
     - decorder
-    # - depguard
+    - depguard
     - dogsled
     - dupl
     - dupword
@@ -24,23 +24,24 @@ linters:
     - errname
     - errorlint
     - exhaustive
-    # - exhaustruct
+    - exhaustruct
     - exptostd
     - fatcontext
-    # - forbidigo
+    - forbidigo
     - forcetypeassert
+    - funcorder
     - funlen
     - ginkgolinter
     - gocheckcompilerdirectives
-    # - gochecknoglobals
-    # - gochecknoinits
+    - gochecknoglobals
+    - gochecknoinits
     - gochecksumtype
     - gocognit
     - goconst
     - gocritic
     - gocyclo
-    # - godot
-    # - godox
+    - godot
+    - godox
     - goheader
     - gomoddirectives
     - gomodguard
@@ -69,12 +70,12 @@ linters:
     - nilerr
     - nilnesserr
     - nilnil
-    # - nlreturn
+    - nlreturn
     - noctx
     - nolintlint
     - nonamedreturns
     - nosprintfhostport
-    # - paralleltest
+    - paralleltest
     - perfsprint
     - prealloc
     - predeclared
@@ -90,22 +91,25 @@ linters:
     - staticcheck
     - tagalign
     - tagliatelle
-    # - testableexamples
+    - testableexamples
     - testifylint
-    # - testpackage
+    - testpackage
     - thelper
     - tparallel
     - unconvert
     - unparam
     - unused
     - usestdlibvars
-    # - usetesting
+    - usetesting
     - varnamelen
     - wastedassign
     - whitespace
-    # - wrapcheck
-    # - wsl
+    - wrapcheck
+    - wsl
     - zerologlint
+  disable:
+    - gochecknoglobals
+    - gochecknoinits
   exclusions:
     generated: lax
     presets:
@@ -117,12 +121,36 @@ linters:
       - third_party$
       - builtin$
       - examples$
+  settings:
+    depguard:
+      rules:
+        prevent_unmaintained_packages:
+          list-mode: lax # allow unless explicitely denied
+          allow:
+            - github.com/stretchr/testify/*
+          deny:
+            - pkg: io/ioutil
+              desc: "replaced by io and os packages since Go 1.16: https://tip.golang.org/doc/go1.16#ioutil"
+    exhaustruct:
+      exclude:
+        - '.+/cobra\.Command$'
+        - '.+/grpcserver\.SimpleGrpcServer$'
+        - '.+/observer\.RawObserver$'
+        - '.+/observer\.SimpleObserver$'
+        - '.+/subject\.SimpleSubject$'
+
+    ireturn:
+      allow:
+        - anon
+        - empty
+        - error
+        - stdlib
 
 formatters:
   enable:
     - gci
     - gofmt
-    # - gofumpt
+    - gofumpt
     - goimports
     - golines
   exclusions:
@@ -131,3 +159,6 @@ formatters:
       - third_party$
       - builtin$
       - examples$
+  settings:
+    golines:
+      max-len: 120

.github/workflows/go-proxy-pull.yaml

@@ -22,7 +22,7 @@ jobs:
 
   slack-notification:
     needs: [go-proxy-pull]
-    if: ${{ always() && contains(fromJSON('["failure", "cancelled"]'), needs.go-proxy-pull.outputs.status ) }}
+    if: ${{ always() && contains(fromJSON('["failure", "cancelled"]'), needs.go-proxy-pull.outputs.status) }}
     secrets:
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
     uses: senzing-factory/build-resources/.github/workflows/build-failure-slack-notification.yaml@v2

.github/workflows/go-test-darwin.yaml

@@ -21,7 +21,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup go
+      - name: Setup go ${{ matrix.go }}
         uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}

.github/workflows/go-test-linux.yaml

@@ -23,7 +23,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup go
+      - name: Setup go ${{ matrix.go }}
         uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}

.github/workflows/go-test-windows.yaml

@@ -20,7 +20,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup go
+      - name: Setup go ${{ matrix.go }}
         uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go }}

.github/workflows/golangci-lint.yaml

@@ -16,6 +16,9 @@ jobs:
   golangci:
     name: lint
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go: ["1.24"]
 
     steps:
       - name: Checkout repository
@@ -26,7 +29,7 @@ jobs:
       - name: Setup go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21
+          go-version: ${{ matrix.go }}
 
       - name: Perform linting
         uses: golangci/golangci-lint-action@v7

.github/workflows/govulncheck.yaml

@@ -0,0 +1,32 @@
+name: govulncheck
+
+on:
+  push:
+    branches-ignore: [main]
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  govulncheck:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go: ["1.24"]
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup go
+        uses: actions/setup-go@v5
+        with:
+          go-version: ${{ matrix.go }}
+
+      - uses: golang/govulncheck-action@v1
+        with:
+          go-version-input: ${{ matrix.go }}

.github/workflows/spellcheck.yaml

@@ -0,0 +1,19 @@
+name: spellcheck
+
+on:
+  pull_request:
+    branches: [main]
+
+permissions:
+  contents: read
+
+jobs:
+  spellcheck:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: streetsidesoftware/cspell-action@v6
+        with:
+          config: .vscode/cspell.json

.gitignore

@@ -24,7 +24,8 @@ go.work
 .DS_STORE
 
 # Visual Studio code
-.vscode
+.vscode/*
+!.vscode/cspell.json
 *.code-workspace
 .history
 

.vscode/cspell.json

@@ -0,0 +1,77 @@
+{
+  "version": "0.2",
+  "language": "en",
+  "words": [
+    "andrewslotin",
+    "aquilax",
+    "buildx",
+    "CCLA",
+    "CFLAGS",
+    "cmdhelping",
+    "CODEOWNER",
+    "CONFIGPATH",
+    "covermode",
+    "coverpkg",
+    "coverprofile",
+    "dockerhub",
+    "dockter",
+    "DYLD",
+    "examplepackage",
+    "godoc",
+    "golangci",
+    "gomod",
+    "GOPATH",
+    "goroutines",
+    "gosec",
+    "gotest",
+    "gotestfmt",
+    "gotesttools",
+    "govulncheck",
+    "ICLA",
+    "LDFLAGS",
+    "OSARCH",
+    "OSTYPE",
+    "pkill",
+    "pydevproject",
+    "RESOURCEPATH",
+    "rootfs",
+    "Senzing",
+    "senzingapi",
+    "SENZINGSDK",
+    "stackoverflow",
+    "stretchr",
+    "SUPPORTPATH",
+    "szapi",
+    "Szconfig",
+    "szconfigmanager",
+    "szconfigmgr",
+    "Szdiagnostic",
+    "Szengine",
+    "szerror",
+    "szerrors",
+    "szerrortypes",
+    "szhelpers",
+    "szinterface",
+    "Szproduct",
+    "SZSDK",
+    "taskkill",
+    "testcoverage",
+    "testdata",
+    "testrecords",
+    "truthset",
+    "unmarshalling",
+    "USERPROFILE",
+    "wraperror"
+  ],
+  "ignorePaths": [
+    ".dockerignore",
+    ".git/*",
+    ".github/linters/.golangci.yaml",
+    ".history/*",
+    ".gitignore",
+    "**/*.go",
+    "**/*.mod",
+    "**/*.sum",
+    "Makefile"
+  ]
+}

CHANGELOG.md

@@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning].
 
 -
 
+## [0.3.2] - 2025-04-28
+
+### Changed in 0.3.2
+
+- Update dependencies
+
 ## [0.3.1] - 2024-09-09
 
 ### Changed in 0.3.1
@@ -95,7 +101,6 @@ and this project adheres to [Semantic Versioning].
 
 - Initial functionality
 
-
 [Keep a Changelog]: https://keepachangelog.com/en/1.0.0/
 [markdownlint]: https://dlaa.me/markdownlint/
 [Semantic Versioning]: https://semver.org/spec/v2.0.0.html