Skip to content

Comments

Bump @angular/core from 19.2.17 to 19.2.18#824

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/angular/core-19.2.18
Closed

Bump @angular/core from 19.2.17 to 19.2.18#824
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/angular/core-19.2.18

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2026

Bumps @angular/core from 19.2.17 to 19.2.18.

Release notes

Sourced from @​angular/core's releases.

19.2.18

core

Commit Description
fix - 26cdc53d9c sanitize sensitive attributes on SVG script elements
Changelog

Sourced from @​angular/core's changelog.

19.2.18 (2026-01-07)

core

Commit Type Description
26cdc53d9c fix sanitize sensitive attributes on SVG script elements

21.0.7 (2026-01-07)

compiler

Commit Type Description
8e808740c9 fix better types for a few expression AST nodes
63b1cdcf70 fix produce accurate span for typeof and void expressions
3c3ae0cb64 fix provide location information for literal map keys
523dbaf1c3 fix stop ThisReceiver inheritance from ImplicitReceiver

compiler-cli

Commit Type Description
4d9c4567ed fix ensure component import diagnostics are reported within the imports expression
cd405685af fix fix up spelling of diagnostic
778460fcca fix support qualified names in typeof type references

core

Commit Type Description
7c74674eb0 fix avoid leaking view data in animations
0edbee4550 fix explicitly cast signal node value to String
f9c29572d2 fix sanitize sensitive attributes on SVG script elements

forms

Commit Type Description
e3fba182f9 feat add [formField] directive
561772b152 fix allow custom controls to require dirty input
f0fb1d8581 fix allow custom controls to require hidden input
ec110f170b fix allow custom controls to require pending input
ae1dc16bb0 fix clean up abort listener after timeout
9748b0d5da fix support custom controls with non signal-based models
6bd22df987 fix Support readonly arrays in signal forms

router

Commit Type Description
41cd4a6af8 fix Fix RouterLink href not updating with queryParamsHandling
5e9e09aee0 fix handle errors from view transition updateCallbackDone promise

21.0.6 (2025-12-17)

Breaking Changes (affecting only experimental features)

... (truncated)

Commits
  • 26cdc53 fix(core): sanitize sensitive attributes on SVG script elements
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) from 19.2.17 to 19.2.18.
- [Release notes](https://github.com/angular/angular/releases)
- [Changelog](https://github.com/angular/angular/blob/main/CHANGELOG.md)
- [Commits](https://github.com/angular/angular/commits/v19.2.18/packages/core)

---
updated-dependencies:
- dependency-name: "@angular/core"
  dependency-version: 19.2.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Change requested in dependencies label Feb 1, 2026
@dependabot dependabot bot requested a review from a team as a code owner February 1, 2026 12:24
@dependabot dependabot bot added javascript Pull requests that update Javascript code dependencies Change requested in dependencies labels Feb 1, 2026
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

🤖 Claude Code Review

Code Review Analysis

Summary

This is a dependency update PR that bumps @angular/core from version 19.2.17 to 19.2.18. This is a patch-level update, likely containing bug fixes or minor improvements.

Detailed Review Against Checklist

Code Quality

Code follows style guide - N/A for dependency updates. No actual code changes to review.

No commented-out code - No commented code present.

Meaningful variable names - N/A for dependency updates.

DRY principle followed - N/A for dependency updates.

Identify Defects - No defects identified. This is a straightforward dependency version bump. The changes are consistent across both package.json and package-lock.json.

⚠️ Project memory configuration - No .claude/CLAUDE.md file found to consider.

Testing

⚠️ Unit tests for new functions - N/A for dependency updates. However, it's recommended to:

  • Run existing test suite to ensure no breaking changes
  • Verify application builds successfully
  • Test core Angular functionality that may be affected by the core framework update

⚠️ Integration tests for new endpoints - N/A for dependency updates.

⚠️ Edge cases covered - N/A for dependency updates.

⚠️ Test coverage > 80% - Cannot verify from diff. Recommend running coverage report to ensure no regression.

Documentation

Readme updated if needed - No README update needed for patch-level dependency updates.

API docs updated - No API changes in this PR.

Inline comments for complex logic - N/A for dependency updates.

CHANGELOG.md updated - No CHANGELOG.md update detected. Even for dependency updates, it's good practice to document version bumps, especially for core dependencies like @angular/core.

Markdown files formatting - N/A, no markdown file changes in this PR.

Security

No hardcoded credentials - None detected.

Input validation implemented - N/A for dependency updates.

Proper error handling - N/A for dependency updates.

No sensitive data in logs - None detected.

No license files (.lic) or AQAAAD strings - None detected.

Issues Found

Minor Issue

Location: Root directory
Issue: Missing CHANGELOG.md entry for dependency update
Recommendation: Add an entry documenting the Angular core version bump from 19.2.17 to 19.2.18

Additional Observations

  1. Version consistency: Note that other Angular packages (@angular/cdk, @angular/common, @angular/compiler, etc.) remain at version 19.2.16. This is acceptable but consider updating all Angular packages together in future updates for consistency.

  2. Lock file integrity: The package-lock.json changes are properly synchronized with package.json changes.

  3. Patch version update: This is a patch-level update (19.2.17 → 19.2.18), which typically contains bug fixes and should be low-risk.

Recommendations

  1. Approve - This is a clean dependency update
  2. 📝 Add CHANGELOG.md entry (optional but recommended)
  3. 🧪 Run full test suite before merging
  4. 🔍 Review Angular 19.2.18 release notes for any relevant changes

Overall Assessment

Status: ✅ APPROVED with minor documentation suggestion

This is a straightforward, low-risk dependency update that follows proper practices. The only improvement would be adding a CHANGELOG entry for tracking purposes.

Automated code review analyzing defects and coding standards

arawinters added a commit that referenced this pull request Feb 4, 2026
Updates all Angular packages to 19.2.18 for stability:
- @angular/animations: 19.2.16 → 19.2.18
- @angular/cdk: 19.2.16 → 19.2.18
- @angular/common: 19.2.16 → 19.2.18
- @angular/compiler: 19.2.16 → 19.2.18
- @angular/compiler-cli: 19.2.16 → 19.2.18
- @angular/core: 19.2.16 → 19.2.18
- @angular/elements: 19.2.16 → 19.2.18
- @angular/forms: 19.2.16 → 19.2.18
- @angular/language-service: 19.2.16 → 19.2.18
- @angular/material: 19.2.16 → 19.2.18
- @angular/platform-browser: 19.2.16 → 19.2.18
- @angular/platform-browser-dynamic: 19.2.16 → 19.2.18
- @angular/router: 19.2.16 → 19.2.18

Regenerates lockfile to incorporate transitive dependency updates from
PRs #821, #822, #823, #824, #825.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@arawinters
Copy link
Contributor

Superseded by #826 which combines all dependency updates with a regenerated lockfile.

@arawinters arawinters closed this Feb 4, 2026
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 4, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/angular/core-19.2.18 branch February 4, 2026 22:13
arawinters added a commit that referenced this pull request Feb 4, 2026
…18 (#826)

Updates all Angular packages to 19.2.18 for stability:
- @angular/animations: 19.2.16 → 19.2.18
- @angular/cdk: 19.2.16 → 19.2.18
- @angular/common: 19.2.16 → 19.2.18
- @angular/compiler: 19.2.16 → 19.2.18
- @angular/compiler-cli: 19.2.16 → 19.2.18
- @angular/core: 19.2.16 → 19.2.18
- @angular/elements: 19.2.16 → 19.2.18
- @angular/forms: 19.2.16 → 19.2.18
- @angular/language-service: 19.2.16 → 19.2.18
- @angular/material: 19.2.16 → 19.2.18
- @angular/platform-browser: 19.2.16 → 19.2.18
- @angular/platform-browser-dynamic: 19.2.16 → 19.2.18
- @angular/router: 19.2.16 → 19.2.18

Regenerates lockfile to incorporate transitive dependency updates from
PRs #821, #822, #823, #824, #825.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Change requested in dependencies javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant