Bump the npm_and_yarn group across 1 directory with 2 updates#830
Bump the npm_and_yarn group across 1 directory with 2 updates#830dependabot[bot] wants to merge 3 commits intomainfrom
Conversation
Bumps the npm_and_yarn group with 2 updates in the / directory: [tar](https://github.com/isaacs/node-tar) and [qs](https://github.com/ljharb/qs). Updates `tar` from 6.2.1 to 7.5.7 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.1...v7.5.7) Updates `qs` from 6.14.1 to 6.14.2 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.1...v6.14.2) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.7 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: qs dependency-version: 6.14.2 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
🤖 Claude Code ReviewI'll perform a comprehensive code review of this pull request diff, which appears to be a dependency update for the Angular CLI from version 19.2.12 to 21.1.4, along with its associated dependencies. Code Review - Angular CLI Version BumpCode Quality✅ Code follows our style guideThis is a ✅ No commented-out codeNo commented-out code present. ✅ Meaningful variable namesNot applicable - this is a dependency lockfile. ✅ DRY principle followedNot applicable. ✅ Identify DefectsCRITICAL ISSUE DETECTED:
|
🤖 Claude Code ReviewPR Code ReviewThis PR upgrades Code Quality✅ No commented-out code - The changes are dependency version updates only. ✅ Meaningful variable names - Not applicable. ✅ DRY principle - Not applicable. ❌ Identify Defects — Version Mismatch (Critical)
Angular CLI v21 ships with its own ❌ Identify Defects — Node.js Minimum Version Change (Breaking) Angular CLI v21 requires Angular CLI v21 introduces significant new transitive dependencies not present before:
These are Testing✅ No new application code — No unit or integration test changes are required for a dependency bump alone. Documentation❌ CHANGELOG.md not updated The existing ❌ README.md not updated The README does not specify a Node.js version. With Angular CLI v21 now requiring Security✅ No hardcoded credentials ✅ No sensitive data ✅ No license files (.lic)
The MCP SDK pulls in Summary
The core issue is that upgrading
|
The lockfile was missing chokidar@5.0.0 and readdirp@5.0.0 entries after the grouped dependency bump, causing npm ci to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🤖 Claude Code ReviewPR Code ReviewThis PR updates Code Quality❌ Critical Defect: Angular CLI/Framework Version Mismatch
Angular CLI and the Angular framework are designed to share the same major version. Using CLI v21 with an Angular v19 project is an unsupported configuration and will likely cause build failures or unexpected behavior. The Angular CLI version should remain at ❌ Node.js Version Requirement Change (Breaking)
The CLI v21 transitively introduces several new heavy production/build-tool packages not present before:
All are ✅ No commented-out code — lock file only ✅ No hardcoded credentials or license files Testing✅ N/A — dependency-only change; no application logic modified Documentation❌ CHANGELOG.md not updated A change to a core dev toolchain dependency of this scope should have a CHANGELOG entry. The current latest entry is ❌ README not updated The README does not specify Node.js version requirements. Given that Security✅ No hardcoded credentials ✅ No
Summary
Recommendation: Either revert
|
|
Closing: this PR bumps |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the npm_and_yarn group with 2 updates in the / directory: tar and qs.
Updates
tarfrom 6.2.1 to 7.5.7Changelog
Sourced from tar's changelog.
... (truncated)
Commits
4a37eb97.5.7f4a7aa9fix: properly sanitize hard links containing ..394ece67.5.67d4cc17fix race puting a Link ahead of its target File26ab9047.5.5e9a1ddbfix: do not prevent valid linkpaths within archive911c8867.5.43b1abfanormalize out unicode ligaturesa43478cremove some unused files970c58fupdate depsMaintainer changes
This version was pushed to npm by isaacs, a new releaser for tar since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Updates
qsfrom 6.14.1 to 6.14.2Changelog
Sourced from qs's changelog.
Commits
bdcf0c7v6.14.2294db90[readme] document thataddQueryPrefixdoes not add?to empty output5c308e5[readme] clarifyparseArraysandarrayLimitdocumentation6addf8c[Fix]parse: mark overflow objects for indexed notation exceedingarrayLimitcfc108f[Fix]arrayLimitmeans max count, not max index, incombine/merge/`pars...febb644[Fix]parse: throw onarrayLimitexceeded with indexed notation when `thr...f6a7abf[Fix]parse: enforcearrayLimitoncomma-parsed valuesfbc5206[Fix]parse: fix error message to reflect arrayLimit as max index; remove e...1b9a8b4[actions] fix rebase workflow permissions2a35775[meta] fix changelog typo (arrayLength→arrayLimit)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.