Made diffprettytext replace invisibles with unicode characters#126
Open
NickyBoy89 wants to merge 2 commits intosergi:masterfrom
Open
Made diffprettytext replace invisibles with unicode characters#126NickyBoy89 wants to merge 2 commits intosergi:masterfrom
NickyBoy89 wants to merge 2 commits intosergi:masterfrom
Conversation
chiragjn
added a commit
to truefoundry/go-diff
that referenced
this pull request
Mar 3, 2023
|
Bump on this, this is a very useful change @sergi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure is this is the best method to do this, but this PR replaces invisible characters in the
Insert/Deletediffs, so that these characters can be seen and fixed, instead of not being able to tell between diffs that look the same but have unequal whitespace, which is something that I have been struggling with.The ways that I can see to implement this are:
DiffPrettyTextfunction, where all spaces are converted into the Unicode Full Block character, and returns are replaced by the Unicode return symbol. (This PR)