Open
Conversation
mrobinson
requested changes
Mar 10, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Hrm. I think we should be consistent with the naming. Maybe simply modify the return value of these functions and we can save this change for right before a API-breaking release.
Author
|
@mrobinson I like that idea. I've updated the branch to make the naming convention match the others. |
acarl005
force-pushed
the
andy/add-fallible-font-methods-3
branch
from
5f206f6 to
6da364e
Compare
jdm
approved these changes
Dec 23, 2025
Member
|
We'll need to adjust the unit tests as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more fallible font methods a. la #62
The naming conventions for this struct were a little different, not have
get_prefixes. As such, the new names we're as obvious. I addedtry_prefixes but please let me know if there is a better suggestion.