Batch parsing of inline scripts/stylesheets#626
Open
MegaCorn wants to merge 1 commit intoservo:mainfrom
Open
Conversation
Signed-off-by: MegaCorn <jxzzq5566@outlook.com>
Contributor
|
html5ever/html5ever/src/tokenizer/mod.rs Lines 258 to 260 in a7c9d98 I'd like to get rid of the line count at some point, because it also has a significant performance overhead in other places (#601 (comment)), but I have not investigated the implications. |
Member
|
The line count is important for providing useful error information for CSS and JS errors/warnings in inline style/script blocks. |
Member
|
Perhaps there is some way to increase the line number by the number of \n characters present in the batched results after leaving the raw text state or something like that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: html5ever produces tokens for each line of inline content
After: html5ever batchs inline contents until encounter '<', which represents endtag in most cases
Fixes: servo/servo#34502