Upgrade ipc-channel to 0.21
#486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Jan 27, 2026
Contributor
Author
|
@mrobinson I am not sure what is up with the workflow. Does a maintainer need to do something? |
Member
|
Build failure: |
Contributor
Author
|
@sagudev Should then ipc-channel be bumped now or should I first have this merged with github refs? |
auto-merge was automatically disabled
January 28, 2026 16:38
Head branch was pushed to by a user without write access
Contributor
Author
|
Ok I temporarily made the github revision for ipc-channel. |
Narfinger
force-pushed
the
ipc-channel
branch
from
21f3c13 to
cd187ac
Compare
Member
|
I think you should also open companion PR in servo that would use git revision of ipc channel and servo-media, then do a try ron on it and if it's all okay we should do the bump and land the PRs one by one. |
Contributor
Author
|
Companion PRs are servo/servo#42161 and this one. |
Member
|
This can use the published version now. |
Narfinger
force-pushed
the
ipc-channel
branch
from
cd187ac to
1a16e67
Compare
Contributor
Author
|
Updated. |
Narfinger
force-pushed
the
ipc-channel
branch
from
1a16e67 to
88c9783
Compare
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
jdm
approved these changes
Feb 3, 2026
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 9, 2026
This updates ipc-channel. Companion Pr in servo media: servo/media#486 This currently uses git revisions temporarily. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> Testing: Full try run here: https://github.com/Narfinger/servo/actions/runs/21471578693 Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ipc-channel version.
Because the revision is fixed in servo this should be merged before servo but after ipc-channel release.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com