Added BigInt64 and BigUint64 Typed Array Support#416
Open
redfire75369 wants to merge 4 commits intoservo:mainfrom
Open
Added BigInt64 and BigUint64 Typed Array Support#416redfire75369 wants to merge 4 commits intoservo:mainfrom
redfire75369 wants to merge 4 commits intoservo:mainfrom
Conversation
sagudev
requested changes
Sep 23, 2023
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
Could you also add them to this test: https://github.com/servo/mozjs/blob/master/mozjs/tests/typedarray.rs
Contributor
Author
|
The current version of that test already does not test for all the different variants of TypedArrays. For example, none of the |
redfire75369
force-pushed
the
typed-array/bigint
branch
2 times, most recently
from
ada7c01 to
9af269c
Compare
redfire75369
force-pushed
the
typed-array/bigint
branch
from
9af269c to
db29bc0
Compare
jdm
approved these changes
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.