refactor(basecamp): move HTTP plumbing to Connections::Rest

[seuros]

=

[Copilot]

Pull Request Overview

This PR refactors the HTTP plumbing by moving shared connection logic into the new Connections module, streamlining REST and GraphQL communication across different adapters.

• Introduces reusable Connection modules (Rest, Pagination, Base, and GraphQl) that consolidate HTTP client functionality.
• Updates adapter-specific connection implementations (Trello, Jira, Basecamp) to use the new REST connection logic, and removes redundant adapter pagination code.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/active_project/connections/rest.rb	Adds the reusable REST connection module for normal APIs.
lib/active_project/connections/pagination.rb	Provides pagination helpers for both REST and GraphQL APIs.
lib/active_project/connections/http_client.rb	Refactors HTTP client logic with updated connection building and error handling.
lib/active_project/connections/graph_ql.rb	Adds GraphQL connection logic using the new connection framework.
lib/active_project/connections/base.rb	Centralizes shared connection helpers and link-header parsing.
lib/active_project/adapters/trello/connection.rb	Updates to use the new Connections::Rest for Trello API connectivity.
lib/active_project/adapters/jira/connection.rb	Migrates Jira connection logic to use Connections::Rest and updates error checking.
lib/active_project/adapters/basecamp/connection.rb	Refactors Basecamp adapter to utilize the new REST connection module.
lib/active_project/adapters/pagination.rb (deleted)	Removed redundant pagination logic now handled by the Connections module.

Comments suppressed due to low confidence (2)

lib/active_project/connections/http_client.rb:61

• [nitpick] Consider revising or removing the humorous reference to 'George Santos' in the error comment to maintain a professional tone and clarity.

when 401, 403 then ActiveProject::AuthenticationError.new(msg)  # Your credentials are like George Santos, fake and sad.

lib/active_project/connections/base.rb:50

• [nitpick] Consider removing or toning down the humorous commentary in the error message comment to ensure that error messages remain clear and professional for production use.

when 404
          ActiveProject::NotFoundError.new(msg)  # Sacral chakra disturbance. The thing you desire does not exist. Embrace the void.