fix: Update the coalesced heartbeat logic to send all heartbeats in a…#32
Open
fix: Update the coalesced heartbeat logic to send all heartbeats in a…#32
Conversation
shaj13
force-pushed
the
CoalescedHeartbeat
branch
3 times, most recently
from
b318527 to
8ca8e4b
Compare
… single message per node, instead of one heartbeat per node. This enables support for multiple leaders per node, one for each group, rather than a single leader per node.
|
@shaj13 please when is this PR going to be merged? |
Owner
Author
It looks like no, there’s regression with it, considering disabling coalesced heartbeats entirely until we can implement improvements to make it stable again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… single message per node, instead of one heartbeat per node. This enables support for multiple leaders per node, one for each group, rather than a single leader per node.