Open
Conversation
shakee93
requested changes
Mar 12, 2020
Owner
shakee93
left a comment
shakee93
left a comment
There was a problem hiding this comment.
can you please check this with the latest version. so i can accept this pull
Author
|
hey sorry for the late reply! would you still be interested in me checking out the latest version? |
Author
|
I've merged the latest master into my branch. Let me know if there's anything else I need to change :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I noticed vue-toasted is still using the babel-preset-2015.
Babel seems to be recommending to use babel-preset-env and relying on browserslist to figure out what features needs to be transpiled.
I've also set
builtInstousageso polyfills withcore-jsare automatically added in. This way polyfills don't need to be manually added (related to #143)Not sure what is recommended for library authors in regards to core-js polyfills actually. I can look into this later if you like?
node-sass was also failing to build for me (on NodeJS 12), that's why I upgraded it.