Move ztwim-test-generator inside oape plugin#12
Conversation
- Add ZTWIM test generator under plugins/oape/ztwim-test-generator (fixtures, docs) - Add oape commands: ztwim-generate-all, ztwim-generate-from-pr, ztwim-generate-execution-steps, ztwim-generate-e2e-from-pr - Add ZTWIM skill at plugins/oape/skills/ztwim-test-case-generator/SKILL.md - Update root README and plugins/oape/README with ZTWIM commands and /oape:ztwim-* usage - Remove duplicate ztwim plugin; all ZTWIM functionality now under oape Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughAdds comprehensive documentation and fixtures for a new ZTWIM Test Generator feature within the oape plugin. Includes command specifications for generating test cases, execution steps, and e2e code from pull requests, along with skill definitions, deployment fixtures, and reference documentation for OpenShift Zero Trust Workload Identity Manager e2e testing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@plugins/oape/commands/ztwim-generate-all.md`:
- Around line 10-12: The code fence in the synopsis for the
/oape:ztwim-generate-all command lacks a language identifier; update the
triple-backtick block that contains "/oape:ztwim-generate-all <pr-url> [--output
<path>] [--env <cluster-type>]" to include a language token (e.g., shell) after
the opening backticks so the fence reads ```shell and matches the rest of the
docs and satisfies markdownlint MD040.
In `@plugins/oape/commands/ztwim-generate-e2e-from-pr.md`:
- Around line 10-12: The fenced code blocks showing the command usage and
examples lack a language tag (triggering MD040); update the fences around the
command snippets in plugins/oape/commands/ztwim-generate-e2e-from-pr.md (the
blocks containing "/oape:ztwim-generate-e2e-from-pr <pr-url> [--output <path>]"
and the example invocations like "/oape:ztwim-generate-e2e-from-pr
https://github.com/openshift/zero-trust-workload-identity-manager/pull/123") to
include a language label (e.g., use ```text or ```bash) so the markdown linter
stops flagging MD040, and apply the same change to the other affected fences
around lines noted (the second example block as well).
In `@plugins/oape/commands/ztwim-generate-execution-steps.md`:
- Around line 10-12: The fenced code blocks in
plugins/oape/commands/ztwim-generate-execution-steps.md (the synopsis block
containing "/oape:ztwim-generate-execution-steps <pr-url>..." and the example
blocks showing command usage) are missing language tags; update those
triple-backtick fences to include a language tag such as text (or bash) so they
become ```text (or ```bash) to satisfy MD040 and ensure proper highlighting;
apply the same change to the other example fence referenced around lines 118-124
so all command/code fences in this file include a language tag.
In `@plugins/oape/commands/ztwim-generate-from-pr.md`:
- Around line 10-12: The fenced code blocks in
plugins/oape/commands/ztwim-generate-from-pr.md are missing language identifiers
(MD040); update the three code fences that show the command usage and examples
so they start with a language tag (e.g., ```shell) instead of just ```;
specifically add the language identifier to the synopsis fence containing
"/oape:ztwim-generate-from-pr <pr-url> [--output <path>]" and to the example
fences containing "/oape:ztwim-generate-from-pr
https://github.com/openshift/zero-trust-workload-identity-manager/pull/72" (and
the variant with --output .work) so markdownlint MD040 is satisfied.
| ``` | ||
| /oape:ztwim-generate-all <pr-url> [--output <path>] [--env <cluster-type>] | ||
| ``` |
There was a problem hiding this comment.
Add a language identifier to the synopsis code fence (MD040).
This keeps markdownlint clean and consistent with other docs.
✅ Suggested fix
-```
+```shell
/oape:ztwim-generate-all <pr-url> [--output <path>] [--env <cluster-type>]</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.20.0)</summary>
[warning] 10-10: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
In @plugins/oape/commands/ztwim-generate-all.md around lines 10 - 12, The code
fence in the synopsis for the /oape:ztwim-generate-all command lacks a language
identifier; update the triple-backtick block that contains
"/oape:ztwim-generate-all [--output ] [--env ]" to
include a language token (e.g., shell) after the opening backticks so the fence
reads ```shell and matches the rest of the docs and satisfies markdownlint
MD040.
</details>
<!-- fingerprinting:phantom:poseidon:eagle -->
<!-- This is an auto-generated comment by CodeRabbit -->
| ``` | ||
| /oape:ztwim-generate-e2e-from-pr <pr-url> [--output <path>] | ||
| ``` |
There was a problem hiding this comment.
Add language tags to fenced code blocks.
The synopsis and examples fences don’t specify a language, which triggers MD040. Consider tagging them as text (or bash if you prefer).
🔧 Suggested tweak
-```
+```text
/oape:ztwim-generate-e2e-from-pr <pr-url> [--output <path>]@@
- +text
/oape:ztwim-generate-e2e-from-pr https://github.com/openshift/zero-trust-workload-identity-manager/pull/123
Writes: output/ztwim_pr_123/123_test_e2e.go, output/ztwim_pr_123/e2e-suggestions.md
/oape:ztwim-generate-e2e-from-pr https://github.com/openshift/zero-trust-workload-identity-manager/pull/123 --output .work
Writes: .work/ztwim_pr_123/123_test_e2e.go, .work/ztwim_pr_123/e2e-suggestions.md
</details>
Also applies to: 103-109
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.20.0)</summary>
[warning] 10-10: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
In @plugins/oape/commands/ztwim-generate-e2e-from-pr.md around lines 10 - 12,
The fenced code blocks showing the command usage and examples lack a language
tag (triggering MD040); update the fences around the command snippets in
plugins/oape/commands/ztwim-generate-e2e-from-pr.md (the blocks containing
"/oape:ztwim-generate-e2e-from-pr [--output ]" and the example
invocations like "/oape:ztwim-generate-e2e-from-pr
https://github.com/openshift/zero-trust-workload-identity-manager/pull/123") to
include a language label (e.g., use text or bash) so the markdown linter
stops flagging MD040, and apply the same change to the other affected fences
around lines noted (the second example block as well).
</details>
<!-- fingerprinting:phantom:triton:eagle -->
<!-- This is an auto-generated comment by CodeRabbit -->
| ``` | ||
| /oape:ztwim-generate-execution-steps <pr-url> [--output <path>] [--env <cluster-type>] | ||
| ``` |
There was a problem hiding this comment.
Add language tags to fenced code blocks.
The synopsis and examples fences are missing language tags (MD040). Tag them as text (or bash if preferred).
🔧 Suggested tweak
-```
+```text
/oape:ztwim-generate-execution-steps <pr-url> [--output <path>] [--env <cluster-type>]@@
- +text
/oape:ztwim-generate-execution-steps openshift/zero-trust-workload-identity-manager#72
Writes: output/ztwim_pr_72/execution-steps.md
/oape:ztwim-generate-execution-steps openshift/zero-trust-workload-identity-manager#72 --output .work
Writes: .work/ztwim_pr_72/execution-steps.md
</details>
Also applies to: 118-124
<details>
<summary>🤖 Prompt for AI Agents</summary>
In @plugins/oape/commands/ztwim-generate-execution-steps.md around lines 10 -
12, The fenced code blocks in
plugins/oape/commands/ztwim-generate-execution-steps.md (the synopsis block
containing "/oape:ztwim-generate-execution-steps ..." and the example
blocks showing command usage) are missing language tags; update those
triple-backtick fences to include a language tag such as text (or bash) so they
become text (or bash) to satisfy MD040 and ensure proper highlighting;
apply the same change to the other example fence referenced around lines 118-124
so all command/code fences in this file include a language tag.
</details>
<!-- fingerprinting:phantom:triton:eagle -->
<!-- This is an auto-generated comment by CodeRabbit -->
| ``` | ||
| /oape:ztwim-generate-from-pr <pr-url> [--output <path>] | ||
| ``` |
There was a problem hiding this comment.
Add language identifiers to fenced code blocks (MD040).
markdownlint flags the synopsis and examples fences as missing a language tag.
✅ Suggested fix
-```
+```shell
/oape:ztwim-generate-from-pr <pr-url> [--output <path>]@@
- +shell
/oape:ztwim-generate-from-pr openshift/zero-trust-workload-identity-manager#72
Writes: output/ztwim_pr_72/test-cases.md
/oape:ztwim-generate-from-pr openshift/zero-trust-workload-identity-manager#72 --output .work
Writes: .work/ztwim_pr_72/test-cases.md
Also applies to: 103-109
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 10-10: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
In `@plugins/oape/commands/ztwim-generate-from-pr.md` around lines 10 - 12, The
fenced code blocks in plugins/oape/commands/ztwim-generate-from-pr.md are
missing language identifiers (MD040); update the three code fences that show the
command usage and examples so they start with a language tag (e.g., ```shell)
instead of just ```; specifically add the language identifier to the synopsis
fence containing "/oape:ztwim-generate-from-pr <pr-url> [--output <path>]" and
to the example fences containing "/oape:ztwim-generate-from-pr
https://github.com/openshift/zero-trust-workload-identity-manager/pull/72" (and
the variant with --output .work) so markdownlint MD040 is satisfied.
2 participants
Summary by CodeRabbit
New Features
Documentation