RPC 機能を実装する #222
Merged
RPC 機能を実装する #222
+466
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
commented
Feb 4, 2026
Contributor
Author
There was a problem hiding this comment.
LLM による commit を防ぐために .gitignore に追加しておきました
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
t-miya
reviewed
Feb 5, 2026
sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/SoraMediaChannel.kt
Outdated
Show resolved
Hide resolved
t-miya
reviewed
Feb 5, 2026
sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/SoraMediaChannel.kt
Show resolved
Hide resolved
t-miya
reviewed
Feb 5, 2026
|
|
||
| const val DEFAULT_TIMEOUT_SECONDS = 10L | ||
|
|
||
| // RPC のデフォルトタイムアウトは 5 秒 |
Contributor
There was a problem hiding this comment.
withTimeout が ミリ秒 要求するからだと思われますが、コメントでは秒表記なので、
補足を入れておいてください。周りの変数も SECONDS なので浮いている
t-miya
reviewed
Feb 5, 2026
| } | ||
| } | ||
|
|
||
| private fun findRpcDataChannel(): DataChannel? = dataChannels["rpc"] |
Contributor
There was a problem hiding this comment.
ワンライナーだし、一箇所からしか呼び出されていないので関数にしなくてもよさそうな？
torikizi
reviewed
Feb 5, 2026
sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/rpc/SoraRpc.kt
Show resolved
Hide resolved
torikizi
reviewed
Feb 6, 2026
sora-android-sdk/src/main/kotlin/jp/shiguredo/sora/sdk/channel/SoraMediaChannel.kt
Outdated
Show resolved
Hide resolved
miosakuma
approved these changes
Feb 10, 2026
Contributor
miosakuma
left a comment
miosakuma
left a comment
There was a problem hiding this comment.
正常動作が確認できました。対応ありがとうございます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.