-
-
Notifications
You must be signed in to change notification settings - Fork 119
Deathmatch mode [WIP] #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
221242e to
7a13a37
Compare
|
I dont see need for deathmatch mode in matchzy. There are dm plugins already and if you wanna just switch between match mode and dm you can load / unload plugins as you go. |
|
Why wouldnt you have it integrated on it? Why having a practice mode when you can load the cfg by yourself? The point is automating or making tasks easier, I want to have one plugin for all my needs :) |
|
Deathmatch mode is not desired by many people and there are already plugins for it. Practice mode is original mode probably without its own good plugin outside of MatchZy. Also Practice mode can be used between games for players to prepare and if they want to play deathmatch they can play on community servers with playerbase consisting of pros and level 9/10s for better preparation. Honestly if you have free time go for it otherwise it is not worth the time. If you need the deathmatch between matches it would be easier to make plugin that unloads matchzy and loads deathmatch and other way around. |
|
This deathmatch is intended when waiting for remaining players to join and be ready for the scrim, is not for doing an official deathmatch server or be on that mode for more than 10 minutes I do like to do deathmatch when we are waiting for the scrim to be live on pracc.com servers they have it, and I think is a good feature |
|
To create another plugin that loads unloads and so on, adds complexity to manage it I dont want to do 5 rcon commands just to have a 5 minutes dm |
|
You can load and unload with plugin by adding listeners and executing commands on server on them. While waiting for remaining players current warmup is ok as players should not be joining for more than 2 minutes if they have match planned regardless. As of right now no other person needs it and it would just bloat codebase because of one person and add more configuration for plugin. You can make it on your fork and have it for yourself. |
|
Have you played scrims with this plugin? I am not targeting tournaments, I get is not useful for that kind of setup. But on scrims, as the pracc.com servers are the standard, they have that feature, and almost everyone like it. "As of right now no other person needs it" on your experience that I guess is for tournaments, again, not scrims :) |
|
The plugin is for running both tournaments and scrims and no other person said they want it right now. Bloating codebase for half usecase with one person interested into the feature is not worth it. |
|
I might as well weigh in now, I am on the side of @Lukseh, adding this is bloat. MatchZy was designed to manage matches and scrims and have a basic practice mode, not managing other modes, the question is where does this stop? If we add deathmatch now, what other modes will we need to patch in in the future. How about Retakes? Executes? All modes that most All-In-One Plugins provide, but MatchZy is, and in my opinion should not turn into, an All-In-One eSports plugin. I would reconsider if this developed into a protocol to interface with MatchZy, i.e. having a custom Deathmatch module that integrates into MatchZy seemlessly with a common API. This would make custom community modules possible and would allow practice mode/scrim mode to be separated into different smaller scale codebases over time, but that would be a enormous task and thinking about it now, that is pretty much what CounterStrikeSharp provides, so I wouldn't be happy if this got merged. The codebase is complicated enough as it is. Just use a CSSharp/Metamod-Deathmatch plugin. If you really need it for some reason you can always maintain your own fork. |
Create a dmsetup.cfg on the server and execute it using Edit:
Since I read this now, this should just be possible to change in the warmup config, just set the spawns to deathmatch spawns in warmup and it should work afaik. I think the option is |
|
I think my addition on this PR, is not a major change for maintenance, it is quite simple and clean You cannot use only a cfg, as you need to change both game_type and game_mode, you need to restart the map. Seeing this I will be back with my own plugin, only focused for scrims and team practice, I guess I will have more freedom and it will be lighter and less complex. |
Work in progress
Feel free to try it and give feedback
I will add some stuff and beautify the coded a bit