Fix multiple value for select#2385
Open
schilchSICKAG wants to merge 1 commit intoshoelace-style:nextfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
claviska
reviewed
Mar 5, 2025
| if (this.multiple) { | ||
| val = Array.isArray(val) ? val : val.split(' '); | ||
| if (!Array.isArray(val)) { | ||
| val = typeof val === 'string' ? val.split(' ') : [val].filter(Boolean); |
Member
There was a problem hiding this comment.
Why are we filtering here? While this removes empty values, wouldn't it also remove '0' and other falsey values that might be intended?
Contributor
Author
There was a problem hiding this comment.
Sorry for the late reply, I was on vacation. You are right, this should just filter out things like 'false' or 'undefined', but certainly not '0'. Will update this and rerequest a review 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2384