Fix code block layout issues caused by floated content#4884
Open
ryxxn wants to merge 2 commits intoshuding:mainfrom
Open
Fix code block layout issues caused by floated content#4884ryxxn wants to merge 2 commits intoshuding:mainfrom
ryxxn wants to merge 2 commits intoshuding:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7f51331 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ryxxn is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
When
floated contentexists in the same area as acode block, the code block’s layout is not calculated correctly, causing thecopy buttonto be rendered in an incorrect position.As shown in the example below, the code block layout overlaps with the floated content.
As a result, the
copy buttonappears to escape outside thecode blockarea.What's being changed (if available, include any code snippets, screenshots, or gifs):
To address this issue,
display: flow-rootis applied to thecode block wrapperto properly contain floated content and prevent layout overlap.Since Nextra uses Tailwind CSS, the
x:flow-rootutility class was added to fix this issue. The result is shown below.Check off the following:
deployment link in this PR's timeline (this link will be available after
opening the PR).
Additional infomation
flow-root MDN
flow-root tailwindcss