feat: talosctl debug
#12392
Merged
feat: talosctl debug
#12392
+3,474
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
force-pushed
the
poc-talos-debug
branch
8 times, most recently
from
ce722ef to
97f4bb2
Compare
laurazard
force-pushed
the
poc-talos-debug
branch
from
97f4bb2 to
431f4bc
Compare
laurazard
force-pushed
the
poc-talos-debug
branch
3 times, most recently
from
95c259b to
79cd19e
Compare
Contributor
Author
|
@smira when you get a sec can you TAL and see if you have any early feedback/ideas? |
laurazard
force-pushed
the
poc-talos-debug
branch
2 times, most recently
from
3da742a to
4d9c6ca
Compare
smira
reviewed
Jan 16, 2026
smira
reviewed
Jan 16, 2026
internal/app/machined/internal/server/v1alpha1/v1alpha1_debug.go
Outdated
Show resolved
Hide resolved
internal/app/machined/internal/server/v1alpha1/v1alpha1_debug.go
Outdated
Show resolved
Hide resolved
smira
force-pushed
the
poc-talos-debug
branch
2 times, most recently
from
5e0b486 to
f9893d7
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 29, 2026
Instead of defaulting to one2many, list explicitly one2many supported APIs. The idea is that any new API will only be "normal" gRPC API, so we can flip the switch, and consider one2many APIs as "legacy". Extracted from siderolabs#12392 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 29, 2026
Instead of defaulting to one2many, list explicitly one2many supported APIs. The idea is that any new API will only be "normal" gRPC API, so we can flip the switch, and consider one2many APIs as "legacy". Extracted from siderolabs#12392 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 29, 2026
Instead of defaulting to one2many, list explicitly one2many supported APIs. The idea is that any new API will only be "normal" gRPC API, so we can flip the switch, and consider one2many APIs as "legacy". Extracted from siderolabs#12392 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
poc-talos-debug
branch
from
f0e025f to
f480d75
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 30, 2026
These new APIs only support one2one proxying, so they don't have any hacks, and look as regular gRPC APIs. Old APIs are deprecated, but still supported. Implement client-side multiplexing in `talosctl`, provide fallback to old APIs for legacy Talos versions. New APIs include removing an image, importing an image. Extracted from siderolabs#12392 Co-authored-by: Laura Brehm <laurabrehm@hey.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 30, 2026
These new APIs only support one2one proxying, so they don't have any hacks, and look as regular gRPC APIs. Old APIs are deprecated, but still supported. Implement client-side multiplexing in `talosctl`, provide fallback to old APIs for legacy Talos versions. New APIs include removing an image, importing an image. Extracted from siderolabs#12392 Co-authored-by: Laura Brehm <laurabrehm@hey.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
poc-talos-debug
branch
from
f480d75 to
9fc874c
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 2, 2026
These new APIs only support one2one proxying, so they don't have any hacks, and look as regular gRPC APIs. Old APIs are deprecated, but still supported. Implement client-side multiplexing in `talosctl`, provide fallback to old APIs for legacy Talos versions. New APIs include removing an image, importing an image. Extracted from siderolabs#12392 Co-authored-by: Laura Brehm <laurabrehm@hey.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
poc-talos-debug
branch
from
9fc874c to
a4a63e2
Compare
smira
force-pushed
the
poc-talos-debug
branch
2 times, most recently
from
3b97cbe to
dac9c15
Compare
This comment was marked as resolved.
This comment was marked as resolved.
smira
force-pushed
the
poc-talos-debug
branch
from
dac9c15 to
214cc09
Compare
smira
force-pushed
the
poc-talos-debug
branch
from
214cc09 to
457bf1b
Compare
smira
force-pushed
the
poc-talos-debug
branch
from
457bf1b to
ceeb029
Compare
frezbo
reviewed
Feb 4, 2026
| } | ||
|
|
||
| // TestRunAlpine tests running a simple alpine container via DebugService. | ||
| func (suite *DebugSuite) TestRunAlpine() { |
Member
There was a problem hiding this comment.
I wonder if we can use this for all other tests that does nsenter
Member
There was a problem hiding this comment.
yep, we could I guess - I can create an issue to transform this, we might still nsenter due to different mount namespace
This implements a way to run a debug container with a provided image on the node. The container runs with privileged profile, allowing to issue debugging commands (e.g. using some advanced network tools) to troubleshoot a machine. Signed-off-by: Laura Brehm <laurabrehm@hey.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
poc-talos-debug
branch
from
ceeb029 to
d43a01c
Compare
Member
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8720