refactor(dashboards): use common util for federation component loading#1440
Merged
spike-rabbit merged 1 commit intomainfrom Feb 6, 2026
Merged
refactor(dashboards): use common util for federation component loading#1440spike-rabbit merged 1 commit intomainfrom
spike-rabbit merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the component creation and error handling logic into a common utility function, handleFederatedModuleLoad. This change significantly reduces code duplication across the module-federation, native-federation, and mf-bridge modules, leading to improved maintainability and consistency. The new utility function is well-designed, handling module loading, component instantiation, and error reporting effectively. The type definitions and error handling within the new utility file are appropriate for the dynamic nature of federated modules. Overall, this is a clean and valuable refactoring.
|
Documentation. Coverage Reports: |
chintankavathia
force-pushed
the
refactor/dashboards/federation-loader
branch
from
dc937b6 to
ed23f8b
Compare
spike-rabbit
requested changes
Feb 6, 2026
chintankavathia
force-pushed
the
refactor/dashboards/federation-loader
branch
2 times, most recently
from
cd33d47 to
ea4bd7c
Compare
Moves component creation and error handling logic from module-federation, native-federation, mf-bridge into common util.
spike-rabbit
force-pushed
the
refactor/dashboards/federation-loader
branch
from
ea4bd7c to
65aa56b
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves component creation and error handling logic from module-federation, native-federation, mf-bridge into common util.