Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the schematics for migrating from v48 to v49. The changes are comprehensive, covering component, input, and output renames, as well as more complex pattern-based replacements, and include a solid suite of new tests. However, I've identified two critical issues in the utility functions that could break existing migrations or fail in complex scenarios. Please see my detailed comments.
spike-rabbit
requested changes
Feb 4, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Please try to break it down into smaller PRs.
- the refactoring from my comment above
- update the migration data
- add new features, which are not covered yet by the current capabilities of
elementMigrationRule
|
Documentation. Coverage Reports: |
mistrykaran91
force-pushed
the
feat/schematics-49
branch
from
d0e70e7 to
cda0495
Compare
mistrykaran91
force-pushed
the
feat/schematics-49
branch
from
cda0495 to
1e3823a
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1401