fix(telecom): use deterministic bill ID for state replay consistency#148
Open
CormickKneey wants to merge 1 commit intosierra-research:mainfrom
Open
fix(telecom): use deterministic bill ID for state replay consistency#148CormickKneey wants to merge 1 commit intosierra-research:mainfrom
CormickKneey wants to merge 1 commit intosierra-research:mainfrom
Conversation
Replace random UUID-based bill ID generation with deterministic ID based on customer_id and billing period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix non-deterministic bill ID generation in telecom domain that causes state replay inconsistency during RL training.
Changes Made
uuid.uuid4().hex[:8]) with deterministic ID based oncustomer_idand billing period ({customer_id}_{YYYYMM})Testing
test_apply_one_time_charge_creates_deterministic_bill_idtest that verifies:Context
During RL training, the environment state needs to be replayed consistently. The original random UUID-based bill ID generation caused non-deterministic behavior - replaying the same actions on the same initial state produced different results due to random bill IDs. This made it impossible to properly validate trajectories during training.
Checklist
make test)make check-all)