Add async version function and custom completion function support#163
Open
dhh1995 wants to merge 4 commits intosierra-research:mainfrom
Open
Add async version function and custom completion function support#163dhh1995 wants to merge 4 commits intosierra-research:mainfrom
dhh1995 wants to merge 4 commits intosierra-research:mainfrom
Conversation
…completion fn support
justinchiu
reviewed
Feb 25, 2026
|
|
||
|
|
||
| def run_domain(config: RunConfig) -> Results: | ||
| def run_domain(config: RunConfig, **kwargs: Any) -> Results: |
There was a problem hiding this comment.
seems like this should be model_kwargs throughout. or even litellm_kwargs
|
i wonder if it make sense to completely remove the sync code and have it be async by default. sync is not great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current tau2 agent, user, and orchestrator only support synced mode, which could be slow when waiting for an LLM completion when being used in an RL framework (e.g., this example).
This PR creates the async version of these synced functions via copy-pasting and changing necessary function calls.
Meanwhile, a custom completion_fn would be useful to override the fixed LiteLLM completion function to add custom changes.