feat(tracking): allow mention tracking to be turned off, turning the …#722
Open
djMax wants to merge 1 commit intosignavio:masterfrom
Open
feat(tracking): allow mention tracking to be turned off, turning the …#722djMax wants to merge 1 commit intosignavio:masterfrom
djMax wants to merge 1 commit intosignavio:masterfrom
Conversation
…input into more of a macro expander
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7af88d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…input into more of a macro expander
What did you change (functionally and technically)?
Instead of inserting the markup into the formatted (and unformatted) values, if trackMentions is false, it will just insert the display-formatted value in both, which allows editing of the FULL text in the text area instead of what happens now. Before this change, if you try to edit the text "in" a mention, it will just delete the whole mention. In our use case it is more of a macro-expander, and thus this breaks the expectations a user would have. There are probably more complex solutions available by messing with applyChangeToValue, but I don't feel confident making those changes.