Remove ssv_types dependency on qbft#105
Merged
jking-aus merged 3 commits intosigp:unstablefrom Jan 16, 2025
Merged
Conversation
jking-aus
approved these changes
Jan 16, 2025
Member
|
I understand the reasoning behind this change and am fine with it. Just wanted to note my reasoning here: I was hoping that |
Member
Author
|
@dknopik okay yea that makes sense. Ill probably work on getting it 100% functional with the ssv type dependency which maps well to the spec and then once we have it working we can look at making it generic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ssv_typeswas importing theqbftcrate which prevented us from using those types in qbft as it created a cyclic dependency. Types should ideally not depend on any other internal crates to prevent this from happening, so I moved theDatatrait into types to keep it contained.