Skip to content

Comments

Remove ssv_types dependency on qbft#105

Merged
jking-aus merged 3 commits intosigp:unstablefrom
Zacholme7:integrate-qbft-message
Jan 16, 2025
Merged

Remove ssv_types dependency on qbft#105
jking-aus merged 3 commits intosigp:unstablefrom
Zacholme7:integrate-qbft-message

Conversation

@Zacholme7
Copy link
Member

Proposed Changes

ssv_types was importing the qbft crate which prevented us from using those types in qbft as it created a cyclic dependency. Types should ideally not depend on any other internal crates to prevent this from happening, so I moved the Data trait into types to keep it contained.

@Zacholme7 Zacholme7 changed the title Integrate qbft message Remove ssv_types dependency on qbft Jan 15, 2025
@Zacholme7 Zacholme7 added the ready-for-review This PR is ready to be reviewed label Jan 15, 2025
@jking-aus jking-aus merged commit 71bdc41 into sigp:unstable Jan 16, 2025
9 checks passed
@dknopik
Copy link
Member

dknopik commented Jan 16, 2025

I understand the reasoning behind this change and am fine with it. Just wanted to note my reasoning here: I was hoping that qbft could stay rather independent, i.e. usable for QBFT consensus without being specific to SSV (which it now is though the dependency on ssv_types).

@Zacholme7
Copy link
Member Author

@dknopik okay yea that makes sense. Ill probably work on getting it 100% functional with the ssv type dependency which maps well to the spec and then once we have it working we can look at making it generic.

@Zacholme7 Zacholme7 deleted the integrate-qbft-message branch January 24, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants