Add basic peer manager by diegomrsantos · Pull Request #108 · sigp/anchor

diegomrsantos · 2025-01-16T17:40:47Z

Issue Addressed

Related to #18

Proposed Changes

Dependencies:

Updated Cargo.toml and anchor/network/Cargo.toml to include new dependencies such as smallvec, arbitrary, delay_map, and itertools.

Network Types:

Added peer_manager module to anchor/network/src/lib.rs.

Network Implementation:

Enhanced anchor/network/src/behaviour.rs and anchor/network/src/network.rs to integrate the PeerManager.
The PeerManager is responsible for managing peer connections, including dialing, connecting, and disconnecting peers.
It includes logic to maintain the target peer count, ensuring the network has the desired number of peers connected.

Peer Manager:

Added a new peer_manager directory with modules for managing peers.
Implemented functionality in PeerManager to handle peer connections, maintain the target peer count, and manage peer discovery.

Additional Info

For now, it's mostly a copy from LH with a few modifications. However, there are efforts to make the LH code more modular, generic, and thus easier to reuse. See sigp/lighthouse#6840 and sigp/lighthouse#6757

diegomrsantos · 2025-01-23T19:14:31Z

anchor/network/src/peer_manager/network_behaviour.rs

+                    self.outbound_ping_peers.insert(peer_id);
+                    self.events.push(PeerManagerEvent::Ping(peer_id));


@AgeManning do you know why we need this? I thought it was handled by libp2p's Ping.

We don't use libp2p ping instead we made our own in our RPC.

For anchor we can remove this, i think.

Cargo.toml

dknopik · 2025-01-24T07:30:16Z

anchor/network/src/peer_manager/mod.rs

+        // Updates peer's scores and unban any peers if required.
+        //let actions = self.peers.write().update_scores();
+        //for (peer_id, action) in actions {
+        //    self.handle_score_action(&peer_id, action, None);
+        //}
+
+        // Update peer score metrics;
+        //self.update_peer_score_metrics();
+
+        // Prune any excess peers back to our target in such a way that incentivises good scores and
+        // a uniform distribution of subnets.
+        //self.prune_excess_peers();
+
+        // Unban any peers that have served their temporary ban timeout
+        //self.unban_temporary_banned_peers();


What's the plan for the commented calls here?

We'll need it eventually, but it's not important for now. The plan is to reuse the LH code anyway.

anchor/network/src/peer_manager/peerdb/client.rs

dknopik · 2025-01-24T07:35:38Z

anchor/network/src/peer_manager/peerdb/peer_info.rs

+    /// The current syncing state of the peer. The state may be determined after it's initial
+    /// connection.
+    sync_status: SyncStatus,


SSV has no sync status communicated via network, right?

I don't know, we need input here. But I'd say it's not important for now.

Yeah, Anchor doesn't sync anything. So can prob remove

diegomrsantos · 2025-01-27T17:11:13Z

We connect at the libp2p level but never perform a handshake with the remote peer, so both sides promptly disconnect. I think we can merge this PR as it is and address this next. It's tracked here #116.

@dknopik @jking-aus thoughts?

AgeManning

I didn't really review this. Looks like most of the stuff we have in Lighthouse.

I think its a good place to start so we can get it up and running then fine-tune, remove parts and maybe modularize lighthouse in the future to not require all the code.

AgeManning · 2025-01-29T08:06:56Z

anchor/network/src/peer_manager/peerdb/client.rs

+}
+
+#[derive(Clone, Copy, Debug, Serialize, PartialEq, AsRefStr, IntoStaticStr, EnumIter)]
+pub enum ClientKind {


We probably should change this just to have Anchor and SSV.

I think they are using libp2p identify, so once we figure out their agent string, we can identify them here.

AgeManning · 2025-01-29T08:07:14Z

anchor/network/src/peer_manager/peerdb/client.rs

+
+// helper function to identify clients from their agent_version. Returns the client
+// kind and it's associated version and the OS kind.
+fn client_from_agent_version(agent_version: &str) -> (ClientKind, String, String) {


We add theirs here

AgeManning · 2025-01-29T08:08:05Z

anchor/network/src/peer_manager/peerdb/peer_info.rs

+use PeerConnectionStatus::*;
+
+#[derive(Clone, Debug, PartialEq, Serialize)]
+pub struct MetaData {


I think this might be their NodeInfo thingy

AgeManning · 2025-01-29T08:09:02Z

anchor/network/src/peer_manager/peerdb/sync_status.rs

+
+#[derive(Clone, Debug, Serialize)]
+/// The current sync status of the peer.
+pub enum SyncStatus {


Most of the stuff in this file we can remove, but fine to keep for now

dknopik · 2025-02-20T13:00:58Z

Closing this, as #126 is now merged. Still, we should keep this one in mind for possible future extensions of the peer manager.

diegomrsantos force-pushed the peer-manager branch from bddd5f5 to e04e07a Compare January 16, 2025 17:42

diegomrsantos changed the title ~~add basic peer manage~~ add basic peer manager Jan 16, 2025

diegomrsantos force-pushed the peer-manager branch 3 times, most recently from 01ebfd7 to d0970c4 Compare January 22, 2025 13:47

diegomrsantos added 4 commits January 23, 2025 14:58

add basic peer manager code

6d3b15c

cargo clippy

d146e1c

refactor and implement network behaviour

ad3366f

cargo fmt

80d0178

diegomrsantos force-pushed the peer-manager branch from d0970c4 to 80d0178 Compare January 23, 2025 14:12

diegomrsantos added 2 commits January 23, 2025 15:14

cargo sort

b56994c

cargo clippy

e58c8d0

diegomrsantos commented Jan 23, 2025

View reviewed changes

diegomrsantos marked this pull request as ready for review January 23, 2025 19:48

diegomrsantos requested review from AgeManning, dknopik and jking-aus and removed request for AgeManning and dknopik January 23, 2025 19:48

dknopik reviewed Jan 24, 2025

View reviewed changes

Merge branch 'unstable' into peer-manager

301f437

diegomrsantos changed the title ~~add basic peer manager~~ Add basic peer manager Jan 27, 2025

changes smallvec version

26638bd

diegomrsantos force-pushed the peer-manager branch from e0979af to 26638bd Compare January 28, 2025 15:59

AgeManning approved these changes Jan 29, 2025

View reviewed changes

diegomrsantos marked this pull request as draft January 29, 2025 14:35

dknopik closed this Feb 20, 2025

		self.outbound_ping_peers.insert(peer_id);
		self.events.push(PeerManagerEvent::Ping(peer_id));

Comments

Conversation

diegomrsantos commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Proposed Changes

Additional Info

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diegomrsantos Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diegomrsantos commented Jan 27, 2025

Uh oh!

AgeManning left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dknopik commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

diegomrsantos commented Jan 16, 2025 •

edited

Loading

diegomrsantos Jan 24, 2025 •

edited

Loading