Merged
Conversation
Member
Author
|
NOTE: converted to draft as I found a bug |
# Conflicts: # anchor/network/src/network.rs
jking-aus
approved these changes
Mar 6, 2025
Member
jking-aus
left a comment
jking-aus
left a comment
There was a problem hiding this comment.
lgtm - just note comment to consider pruning unreachable peers
| (!actions.discover.is_empty() || !actions.dial.is_empty()).then_some(actions) | ||
| } | ||
|
|
||
| fn candidate_peers(&self) -> Vec<(&PeerId, &PeerRecord<Enr>)> { |
Member
There was a problem hiding this comment.
do we ever prune unreachable ENRs? appreciate a restart would fix this but might be worth removing addresses that fail to connect from peer manager? Apologies if this behaviour is captured in libp2p somewhere and I'm unaware
Member
Author
There was a problem hiding this comment.
already metioned this to João. libp2p should handle it. not sure if it made it in in the currently merged version though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement basic heartbeat for peer manager.
Currently, we only check if we need more peers for some subnets, and try to dial if we find some good peers in the peer store. If we can not dial enough peers, we try to discover more.