SignedSSVMessage and SSVMessage validation#160
Merged
jking-aus merged 12 commits intosigp:unstablefrom Mar 6, 2025
Merged
Conversation
diegomrsantos
changed the title
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
99307f9 to
cf10d55
Compare
diegomrsantos
requested review from
Zacholme7,
dknopik and
jking-aus
and removed request for
Zacholme7 and
dknopik
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
cf10d55 to
f9f80a9
Compare
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
6a64b81 to
ca76591
Compare
dknopik
reviewed
Feb 27, 2025
Zacholme7
reviewed
Feb 27, 2025
Member
Zacholme7
left a comment
Zacholme7
left a comment
There was a problem hiding this comment.
Good on my end! Gj. I like the detailed validation errors. These will be good in the qbft crate too. Ill let kingy give this a glad too.
Zacholme7
reviewed
Mar 3, 2025
Member
Author
|
This is waiting for #152 to be merged and then I'll change it to ready. |
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
a0e5a55 to
f1c43e1
Compare
# Conflicts: # anchor/network/src/network.rs
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
ca1a152 to
ae37b67
Compare
diegomrsantos
force-pushed
the
signed-ssv-message-validation
branch
from
ae37b67 to
5e34c68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
It's related to #161
Proposed Changes
We move basic validation inside the messages
Additional Info
This is only the first phase of validation, more PRs will come.