Properly handle messages sent by ourselves#166
Merged
jking-aus merged 2 commits intosigp:unstablefrom Mar 10, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QBFT instance needs to handle messages that it has sent. For this, it needs the signed message - for example, so that it can embed signed quorums in the round change messages.
This PR adds an optional callback mechanism to the common message sender. This is used in the QBFT instance to enqueue signed message for handling by the same instance.
While we're at it, we get rid of
qbft::Message, which is no longer adequate as outgoing message type. The different variants are not treated differently at all in the current design, where we directly use SSV-specific messages.