Embed message id into outgoing qbft messages#167
Merged
jking-aus merged 3 commits intosigp:unstablefrom Mar 11, 2025
Merged
Conversation
jking-aus
force-pushed
the
embed-message-id
branch
from
6f61917 to
53684cf
Compare
# Conflicts: # anchor/qbft_manager/src/lib.rs
dknopik
force-pushed
the
embed-message-id
branch
from
31061b8 to
ffa48b8
Compare
jking-aus
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to set the correct message ID for outgoing QBFT messages - previously, an all zero ID was used. This PR adds the infrastructure to set this to the message ID as expected by the protocol.