Skip to content

Comments

Set "ssv" field in ENR#177

Merged
jking-aus merged 3 commits intosigp:unstablefrom
dknopik:set-ssv-in-enr
Mar 11, 2025
Merged

Set "ssv" field in ENR#177
jking-aus merged 3 commits intosigp:unstablefrom
dknopik:set-ssv-in-enr

Conversation

@dknopik
Copy link
Member

@dknopik dknopik commented Mar 7, 2025

There is a check for a "ssv" field in the ENR: https://github.com/ssvlabs/ssv/blob/dc0c830e8f0718cc17d61d20fc802887df252569/network/discovery/dv5_filters.go#L39-L49

This PR sets the field in our own ENR. We do not check for it, as that is unneccessary

Copy link
Member

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this

@dknopik dknopik changed the title Set and check for "ssv" field in ENR Set "ssv" field in ENR Mar 11, 2025
@jking-aus jking-aus merged commit 48cd530 into sigp:unstable Mar 11, 2025
10 checks passed
@dknopik dknopik deleted the set-ssv-in-enr branch June 20, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants