Add comments for easier audit of crypto code#187
Merged
jking-aus merged 5 commits intosigp:unstablefrom Mar 18, 2025
Merged
Conversation
Member
|
I assume you mean at line 40 in bls_lagrange/lib.rs? 186 went in so adding ref to secret key result. Just double check that's what you wanted because going deep on blst stuff is above my head right now |
Member
Author
|
@jking-aus yep looks good :) |
jking-aus
approved these changes
Mar 18, 2025
diegomrsantos
pushed a commit
to diegomrsantos/anchor
that referenced
this pull request
Mar 21, 2025
Co-authored-by: Josh King <josh@sigmaprime.io> Co-authored-by: jking-aus <72330194+jking-aus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our crypto code is to be audited soon 🥳
This code adds some comments that explain what is happening.
The attentive reader notices that I talk about passing a reference where we actually don't. The corresponding locations will appropriately change through #186.