Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
anchor/signature_collector/src/lib.rs:145
- Returning an empty signature for impostor mode may lead to silent failures or unexpected behavior in downstream signature validation. Please verify that all consumers of the signature can correctly handle an empty signature.
let partial_signature = if let Some(share) = &validator_signing_data.share {
anchor/client/src/lib.rs:458
- [nitpick] Conditionally providing the key only in non-impostor mode relies on downstream components correctly handling a missing key. Confirm that all functions using the key appropriately accommodate a None value to avoid potential runtime issues.
config.impostor.is_none().then_some(key),
jking-aus
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow providing an arbitrary operator id via CLI, then act as if we are that operator. So spin up qbft instances as usual, subscribe to subnets as usual, etc. The only thing we cant to, is send messages - so we are reliant on the actual operator to kindly do that for us :)
I think this is an interesting mode for load testing, as we do everything we usually do (except signing stuff), as well as a bit of interop testing (receiving go-ssv messages) without actually having to spin up validators.
I am not sure if we actually want to integrate that permanently, as it adds some useless logic, or just keep that branch around for now.