Skip to content

Comments

Impostor Anchor#190

Merged
jking-aus merged 4 commits intosigp:unstablefrom
dknopik:impostor
Apr 17, 2025
Merged

Impostor Anchor#190
jking-aus merged 4 commits intosigp:unstablefrom
dknopik:impostor

Conversation

@dknopik
Copy link
Member

@dknopik dknopik commented Mar 14, 2025

Allow providing an arbitrary operator id via CLI, then act as if we are that operator. So spin up qbft instances as usual, subscribe to subnets as usual, etc. The only thing we cant to, is send messages - so we are reliant on the actual operator to kindly do that for us :​)

I think this is an interesting mode for load testing, as we do everything we usually do (except signing stuff), as well as a bit of interop testing (receiving go-ssv messages) without actually having to spin up validators.

I am not sure if we actually want to integrate that permanently, as it adds some useless logic, or just keep that branch around for now.

@dknopik dknopik marked this pull request as ready for review April 15, 2025 13:10
@dknopik dknopik added the ready-for-review This PR is ready to be reviewed label Apr 15, 2025
@diegomrsantos diegomrsantos requested a review from Copilot April 16, 2025 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

anchor/signature_collector/src/lib.rs:145

  • Returning an empty signature for impostor mode may lead to silent failures or unexpected behavior in downstream signature validation. Please verify that all consumers of the signature can correctly handle an empty signature.
let partial_signature = if let Some(share) = &validator_signing_data.share {

anchor/client/src/lib.rs:458

  • [nitpick] Conditionally providing the key only in non-impostor mode relies on downstream components correctly handling a missing key. Confirm that all functions using the key appropriately accommodate a None value to avoid potential runtime issues.
config.impostor.is_none().then_some(key),

@jking-aus jking-aus merged commit 532fd56 into sigp:unstable Apr 17, 2025
22 checks passed
@dknopik dknopik deleted the impostor branch June 20, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants