Anchor simulator

[Zacholme7]

Issue Addressed

N/A

Proposed Changes

This PR extends on the simulator introduced in lighthouse to add support for anchor.

Note

The tests wont currently pass since some of the node functionality still does not work, but once everything is working all the tests should be drop in. There is also an issue where we will stack overflow a tokio worker after running for a bit. This also occurs in the lighthouse simulator. The culprit is the LocalBeaconClient simply growing too large over the course of execution mixed with some deep async calls. This would require a significant refactor to address, so simply configuring the stack size before running is the way to go.

RUST_MIN_STACK=8388608 cargo run --bin integration basic-sim

[Zacholme7]

Do we have a plan to address this duplication?

There is no way to address it without upstreaming anchor support into the lighthouse simulator which we dont want to do.

Isn't it possible to modularize and generalize the LH Simulator and reuse the common parts in Anchor? Similar to what I planned to do with the Peer Manager? @AgeManning

I will look into it and see if there is anything that can be done. The main issue is that the LH simulator revolves around a LocalNetwork that does not include anchor nodes. This is pretty much used everywhere in the simulator so either I add some wrapper around it here or we just duplicate some code in favor of readability.

[diegomrsantos]

Do we have a plan to address this duplication?

There is no way to address it without upstreaming anchor support into the lighthouse simulator which we dont want to do.

Isn't it possible to modularize and generalize the LH Simulator and reuse the common parts in Anchor? Similar to what I planned to do with the Peer Manager? @AgeManning

I will look into it and see if there is anything that can be done. The main issue is that the LH simulator revolves around a LocalNetwork that does not include anchor nodes. This is pretty much used everywhere in the simulator so either I add some wrapper around it here or we just duplicate some code in favor of readability.

Got it. If you have time, please point me to the more relevant parts in the LH code, and I can try to think about something similar to what I had in mind for the Peer Manager.

[AgeManning]

Yeah, i think in general we want to avoid code duplication. However the simulator, I think can be quite dependent on the thing its simulating.

As its mainly used for CI and testing, I think its fine to just have duplicate code, I'd personally be more concerned with core components. I.e I still think we merge the new Anchor peer manager into Lighthouse at some point. (Maybe that would help with the simulator also).

[Zacholme7]

Thought the stack overflow was resolved but just hit it again, looking into it.

Mentioned in summary

[Zacholme7]

Closing for now