Conversation
|
Few notes from my side:
|
macladson
left a comment
There was a problem hiding this comment.
Just giving this a quick review, but I didn't test anything so was just looking over the code. Hopefully this is helpful
|
Thanks for the review(s)! |
macladson
left a comment
There was a problem hiding this comment.
Didn't get a chance to do a very thorough review but just had some more code structure comments for you
|
Thanks again @macladson !! : ) |
|
Tried this out on interop, there seem to be a few issues. Will dig into it more later. |
|
There seems to be a bug as EDIT: actually, all three log files seem to contain all logs. |
|
Without this branch, With this branch, it returns so apparently, the error is suppressed. |
|
Thanks for catching all the issues ! (& apologies for not testing the changes properly myself) please lmk if i broke anything else this time : ) |
dknopik
left a comment
There was a problem hiding this comment.
small nitpick
Otherwise, LGTM, seems to work well on interop. Can someone else take an additional look before merging?
Issue Addressed
#208
file logging should work now
still need to work on getting libp2p & discv5 logs thoughedit1: (removed the stuff from here,will handle them in separate PR)edit2: added libp2p & discv5 stuff back in here as the fix was small enough