Skip to content

Comments

Disable slashing protection#216

Merged
dknopik merged 7 commits intosigp:unstablefrom
Zacholme7:disable-slashing-protection
Apr 1, 2025
Merged

Disable slashing protection#216
dknopik merged 7 commits intosigp:unstablefrom
Zacholme7:disable-slashing-protection

Conversation

@Zacholme7
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Add cli option to disable slashing protection

@Zacholme7 Zacholme7 added enhancement New feature or request ready-for-review This PR is ready to be reviewed labels Mar 28, 2025
@dknopik
Copy link
Member

dknopik commented Mar 31, 2025

We handle metrics within handle_slashing_check_result, so I suggest passing Safe::Valid to it if slashing protection is disabled instead of not calling it.

@dknopik
Copy link
Member

dknopik commented Apr 1, 2025

General question: What do you think about making this a hidden option? The user should not be tempted - even if there is an all caps warning...

@diegomrsantos
Copy link
Member

Is it for ssv-mini? Isn't it possible to clean the db before running?

@Zacholme7
Copy link
Member Author

@dknopik I think that is a good idea, will update

@Zacholme7
Copy link
Member Author

@diegomrsantos This was prompted by the simulator, not ssv-mini. I did go the route of cleaning the dbs before running, but this is still an option that we should include regardless.

@Zacholme7 Zacholme7 requested a review from dknopik April 1, 2025 12:56
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dknopik dknopik merged commit 96b1ea9 into sigp:unstable Apr 1, 2025
10 checks passed
@Zacholme7 Zacholme7 deleted the disable-slashing-protection branch April 1, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants