Conversation
|
I was considering tackling areas of the codebase where we log and return an error, like in anchor/anchor/eth/src/event_processor.rs Line 193 in 0f74f32 |
Well, ideally we return errors with structured data as long as possible and only turn into a On the other hand, logging where the error originates gives us more information due to active spans that might not be active where they are caught. 🤔 |
We need to capture the backtrace https://docs.rs/anyhow/latest/anyhow/struct.Error.html |
# Conflicts: # anchor/eth/src/event_processor.rs
# Conflicts: # anchor/message_validator/src/consensus_message.rs
diegomrsantos
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work on this
Collection of logging improvements all over the code base.
These changes especially aim to allow debuggability using logfiles sent in by a user, while maintaining a nice overview on the console output without unnecessary detail.