Use Go-SSV key formats, convert legacy keys#404
Merged
mergify[bot] merged 9 commits intosigp:unstablefrom Jul 8, 2025
Merged
Conversation
dknopik
added
ready-for-review
Closed
jking-aus
reviewed
Jul 7, 2025
| password_file: Option<&Path>, | ||
| ) -> Result<Rsa<Private>, String> { | ||
| // First, we have to read a file and decide what to do. | ||
| // TODO: do not hardcode paths here: https://github.com/sigp/anchor/issues/403 |
Member
There was a problem hiding this comment.
yeah agree - let's get this in 0.3
jking-aus
previously approved these changes
Jul 7, 2025
Member
jking-aus
left a comment
jking-aus
left a comment
There was a problem hiding this comment.
nice, couple small nits to consider but I'm ok either way since a lot of this is transitory
17 tasks
diegomrsantos
pushed a commit
to diegomrsantos/anchor
that referenced
this pull request
Sep 17, 2025
- closes sigp#323 - Create new key format in keygen, removing support for writing legacy keys. - Add support for password file for both keygen and node. - If only a legacy key is found, convert it to the new format - Add support for explicitly specifying a key file location.
jking-aus
pushed a commit
to jking-aus/anchor
that referenced
this pull request
Oct 8, 2025
- closes sigp#323 - Create new key format in keygen, removing support for writing legacy keys. - Add support for password file for both keygen and node. - If only a legacy key is found, convert it to the new format - Add support for explicitly specifying a key file location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Additional Info
I got rid of the password read retry loop, as it made the logic too awkward for too little benefit.