refactor(logging): Cleaner logging setup

[dknopik]

Proposed Changes

• Move more logging related logic to the logging crate
• Logging crate had a logging module which was completely reexported. Define items in crate root instead.
• Keep guards unified and separate from logging layers.
• Create discv5 and libp2p layers only once.
• Implement compression of discv5 and libp2p layers

Additional Info

This was originally part of #347

[mergify]

This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏

[diegomrsantos]

Why is it not used?

[mergify]

This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏

[Copilot]

Pull Request Overview

This PR refactors the logging setup by moving logging logic from the main application to the logging crate for better organization and consolidation.

• Consolidates logging setup code in the logging crate by moving enable_logging function from main.rs
• Simplifies the module structure by defining items in the crate root instead of a separate logging module
• Improves guard management by keeping guards unified and separate from logging layers

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
anchor/src/main.rs	Removes logging setup code and imports, delegates to logging crate
anchor/logging/src/lib.rs	Adds consolidated logging setup functions and FileLoggingFlags definition
anchor/logging/src/logging.rs	File deleted - contents moved to lib.rs
anchor/logging/src/tracing_libp2p_discv5_layer.rs	Updates layer creation with compression support and better error handling
anchor/logging/Cargo.toml	Adds global_config dependency

Comments suppressed due to low confidence (1)

anchor/logging/src/tracing_libp2p_discv5_layer.rs:93

• The parameter config has been renamed to logging_config in the function signature but the implementation still references config. This inconsistency could lead to confusion during maintenance.

        .map_err(|e| format!("Failed to initialize discv5 rolling file appender: {e}"))?;

[Copilot]

The function signature change from config: FileLoggingFlags (by value) to config: &FileLoggingFlags (by reference) is a breaking change that could affect existing callers expecting to pass the struct by value.

Suggested change

	config: &FileLoggingFlags,
	config: FileLoggingFlags,

[Copilot]

The return type has changed from Option<LoggingLayer> to Result<Option<LoggingLayer>, String>, which is a breaking change. Existing callers that expect an Option will need to be updated to handle the Result.

Suggested change

	return Ok(None);
	) -> Option<LoggingLayer> {
	if config.disabled_file_logging() {
	return None;

[mergify]

Hi @dknopik, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

[dknopik]

rude

[mergify]

Hi @dknopik, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.