Merged
Conversation
jimmygchen
reviewed
Dec 9, 2024
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Nice! great progress @Zacholme7 👏
I know this is WIP, but I thought some early feedback after a quick read might be helpful.
I've added some comments and questions above, and here are a few more:
- Would be useful to add more logging, both for informative and debug purpose (e.g. sync progress, live events received, fetch or processing errors etc)
- I'd love to see some unit & integration tests where it make sense. It doesn't have to be this PR, but I wanted to mention it since we recently started adding tests in the validator client, and it's been a little painful. Adding tests while the codebase is fresh can make things a bit more testable by design and save some headaches later.
I'm not familiar with SSV, so my comments are mostly generic, but I'd like to catch up and review this again later when it's ready.
Overall it's very tidy and nice to read, great job 👍
…nto execution-integration
jking-aus
reviewed
Jan 13, 2025
| const MAX_RETRIES: i32 = 5; | ||
|
|
||
| // Block follow distance | ||
| const FOLLOW_DISTANCE: u64 = 8; |
Member
There was a problem hiding this comment.
check with ssv on reason for 8 block follow distance
jking-aus
approved these changes
Jan 13, 2025
Member
jking-aus
left a comment
There was a problem hiding this comment.
reviewed in call on 14/1 -- nice work zac good to get this one finished
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
This PR tracks the integration of the execution layer into anchor. The process can be thought of as the following:
Additional Info
Types and the database are being worked on alongside this as they all mesh together.