fix: Version info on root command, consistent output style of help#638
Merged
mergify[bot] merged 4 commits intosigp:release-v1.0.0from Oct 12, 2025
Merged
fix: Version info on root command, consistent output style of help#638mergify[bot] merged 4 commits intosigp:release-v1.0.0from
mergify[bot] merged 4 commits intosigp:release-v1.0.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves command-line interface configuration from the node subcommand to the root anchor command to fix version info display and ensure consistent styling across all subcommands. The changes also remove incorrect allocator information from version output.
- Moved CLI attributes (version, styling, metadata) from node subcommand to root command
- Relocated version formatting and styling functions from client module to main module
- Removed allocator information from version output and updated dependency structure
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| anchor/src/main.rs | Added CLI attributes, version formatting, and styling functions to root command |
| anchor/client/src/cli.rs | Removed CLI metadata and version info, simplified to basic node subcommand |
| anchor/client/Cargo.toml | Removed ethereum_hashing dependency no longer needed in client module |
| anchor/Cargo.toml | Added ethereum_hashing and version dependencies for root module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏 |
|
This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏 |
AgeManning
approved these changes
Oct 12, 2025
petarjuki7
pushed a commit
to petarjuki7/anchor
that referenced
this pull request
Oct 16, 2025
…igp#638) - sigp#631 Originally, we had only the main command, and no sub commands. When subcommands were introduced, certain attributes stayed on the `node` subcommand, even though they should have moved. Move the attributes to the main command, causing correct colour output on all subcommands and allowing `--version` and `-V` to work on all commands. Also, remove incorrect allocator info from version output. Co-Authored-By: Daniel Knopik <daniel@dknopik.de> Co-Authored-By: Age Manning <Age@AgeManning.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Originally, we had only the main command, and no sub commands. When subcommands were introduced, certain attributes stayed on the
nodesubcommand, even though they should have moved.Proposed Changes
Move the attributes to the main command, causing correct colour output on all subcommands and allowing
--versionand-Vto work on all commands.Also, remove incorrect allocator info from version output.