Skip to content

Comments

fix: Version info on root command, consistent output style of help#638

Merged
mergify[bot] merged 4 commits intosigp:release-v1.0.0from
dknopik:fix-version-cli
Oct 12, 2025
Merged

fix: Version info on root command, consistent output style of help#638
mergify[bot] merged 4 commits intosigp:release-v1.0.0from
dknopik:fix-version-cli

Conversation

@dknopik
Copy link
Member

@dknopik dknopik commented Sep 29, 2025

Issue Addressed

Originally, we had only the main command, and no sub commands. When subcommands were introduced, certain attributes stayed on the node subcommand, even though they should have moved.

Proposed Changes

Move the attributes to the main command, causing correct colour output on all subcommands and allowing --version and -V to work on all commands.

Also, remove incorrect allocator info from version output.

@dknopik dknopik added ready-for-review This PR is ready to be reviewed v1.0.0 First Mainnet-release cli labels Sep 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves command-line interface configuration from the node subcommand to the root anchor command to fix version info display and ensure consistent styling across all subcommands. The changes also remove incorrect allocator information from version output.

  • Moved CLI attributes (version, styling, metadata) from node subcommand to root command
  • Relocated version formatting and styling functions from client module to main module
  • Removed allocator information from version output and updated dependency structure

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

File Description
anchor/src/main.rs Added CLI attributes, version formatting, and styling functions to root command
anchor/client/src/cli.rs Removed CLI metadata and version info, simplified to basic node subcommand
anchor/client/Cargo.toml Removed ethereum_hashing dependency no longer needed in client module
anchor/Cargo.toml Added ethereum_hashing and version dependencies for root module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jking-aus
jking-aus previously approved these changes Oct 9, 2025
Copy link
Member

@jking-aus jking-aus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify
Copy link

mergify bot commented Oct 10, 2025

This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏

@mergify mergify bot added waiting-on-author and removed ready-for-review This PR is ready to be reviewed labels Oct 10, 2025
@jking-aus jking-aus added ready-for-review This PR is ready to be reviewed and removed ready-for-merge labels Oct 10, 2025
@mergify
Copy link

mergify bot commented Oct 10, 2025

This pull request has merge conflicts. Could you please resolve them @dknopik? 🙏

@mergify mergify bot removed the ready-for-review This PR is ready to be reviewed label Oct 10, 2025
@dknopik dknopik added ready-for-review This PR is ready to be reviewed and removed waiting-on-author labels Oct 10, 2025
@mergify mergify bot merged commit 8471acb into sigp:release-v1.0.0 Oct 12, 2025
15 checks passed
petarjuki7 pushed a commit to petarjuki7/anchor that referenced this pull request Oct 16, 2025
…igp#638)

- sigp#631

Originally, we had only the main command, and no sub commands. When subcommands were introduced, certain attributes stayed on the `node` subcommand, even though they should have moved.


  Move the attributes to the main command, causing correct colour output on all subcommands and allowing `--version` and `-V` to work on all commands.

Also, remove incorrect allocator info from version output.


Co-Authored-By: Daniel Knopik <daniel@dknopik.de>

Co-Authored-By: Age Manning <Age@AgeManning.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli ready-for-merge ready-for-review This PR is ready to be reviewed v1.0.0 First Mainnet-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants