fix: metrics scraping bug#651
Merged
mergify[bot] merged 3 commits intosigp:release-v1.0.0from Oct 8, 2025
Merged
Conversation
Member
|
Does this still work outside of docker? |
Member
Author
Not sure, in our documentation it says
So I just followed that. |
Member
|
I assume this is configuration for the provided docker compose file. So as this is a docker-specific file anyway, it should be fine. Users setting up their own Prometheus servers provide their own scraping config anyway I am more concerned that this fixes macos and windows but breaks on linux. Will test. |
Member
|
I think it should work without this, as |
AgeManning
approved these changes
Oct 8, 2025
petarjuki7
added a commit
to petarjuki7/anchor
that referenced
this pull request
Oct 16, 2025
Fixes Prometheus unable to scrape metrics from Anchor when running in Docker. Fix a trailing comma and change to `host.docker.internal:5154` Co-Authored-By: petarjuki7 <petar.jukic7@gmail.com> Co-Authored-By: Age Manning <Age@AgeManning.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes Prometheus unable to scrape metrics from Anchor when running in Docker.
Proposed Changes
Fix a trailing comma and change to
host.docker.internal:5154Additional Info
When Prometheus runs in Docker,
localhostrefers to the container, not the host.host.docker.internalis Docker's DNS name for accessing the host machine from containers (macOS/Windows).