-
Notifications
You must be signed in to change notification settings - Fork 28
fix: Prevent dialing connected peers #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 9 commits into
sigp:release-v1.0.0
from
AgeManning:prevent-dialing-connected-peers
Oct 8, 2025
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
20ad647
Prevent dialing already connected peers
AgeManning ec6123f
Merge branch 'release-v1.0.0' into prevent-dialing-connected-peers
AgeManning d2a85d3
Revert poor implementation
AgeManning c91f0b2
Saw this change earlier, figured it's cleaner this way
AgeManning 1138861
Don't dial connected peers
AgeManning accb3f6
Minimal diff
AgeManning 34eabbf
Seocnd attempt minimal diff
AgeManning 2a9dc7f
Merge branch 'release-v1.0.0' into prevent-dialing-connected-peers
AgeManning 8a65ecc
remove unrelated changes
dknopik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,9 +71,10 @@ impl PeerManager { | |
|
|
||
| /// Join subnet and dial peers for it | ||
| pub fn join_subnet(&mut self, subnet_id: SubnetId) -> ConnectActions { | ||
| self.needed_subnets.insert(subnet_id); | ||
|
|
||
| PeerDiscovery::track_subnet_peers( | ||
| subnet_id, | ||
| &mut self.needed_subnets, | ||
| self.peer_store.store(), | ||
|
||
| &self.connection_manager, | ||
| self.blocking_manager.blocked_peers(), | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unrelated?