-
Notifications
You must be signed in to change notification settings - Fork 28
feat: dynamically populate nodeinfo #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aecc9af
feat: calculate subnets for handshake
jking-aus f9db484
rebase on v1.0.0
jking-aus bbfc4a3
cargo fmt
jking-aus 43de84b
clippy please dont look
jking-aus 2cc28c8
Merge branch 'release-v1.0.0' into handshake-subnet
AgeManning f259f5e
adding fetch for node info and refactor to remove db dependency
jking-aus 19221a4
get node versions before init network
jking-aus b984e2b
dup fn
jking-aus 572c187
tidy comment
jking-aus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,25 @@ use metrics::*; | |
| pub static PEERS_CONNECTED: LazyLock<Result<IntGauge>> = LazyLock::new(|| { | ||
| try_create_int_gauge("libp2p_peers", "Count of libp2p peers currently connected") | ||
| }); | ||
|
|
||
| pub static HANDSHAKE_SUCCESSFUL: LazyLock<Result<IntCounter>> = LazyLock::new(|| { | ||
| try_create_int_counter( | ||
| "libp2p_handshake_successful_total", | ||
| "Total count of successful handshakes", | ||
| ) | ||
| }); | ||
|
|
||
| pub static HANDSHAKE_FAILED: LazyLock<Result<IntCounter>> = LazyLock::new(|| { | ||
| try_create_int_counter( | ||
| "libp2p_handshake_failed_total", | ||
| "Total count of failed handshakes", | ||
| ) | ||
| }); | ||
|
|
||
| pub static HANDSHAKE_SUBNET_MATCHES: LazyLock<Result<IntGaugeVec>> = LazyLock::new(|| { | ||
| try_create_int_gauge_vec( | ||
| "libp2p_handshake_subnet_matches", | ||
| "Count of successful handshakes by number of matching subnets", | ||
| &["match_count"], | ||
| ) | ||
| }); | ||
|
Comment on lines
+9
to
+29
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Metrics for the handshake is not really what this PR advertises to do, please open a separate PR |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it is unclear if we actually want to do this. e.g. Go-SSV just leaves the node version in the handshake empty